From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()
Date: Sun, 14 Dec 2014 13:15:38 -0500 [thread overview]
Message-ID: <20141214131538.7a6c1438@gandalf.local.home> (raw)
In-Reply-To: <20141214180854.GC5310@linux.vnet.ibm.com>
On Sun, 14 Dec 2014 10:08:54 -0800
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> On Sun, Dec 14, 2014 at 11:53:32AM -0500, Steven Rostedt wrote:
> > On Sun, 14 Dec 2014 11:41:05 -0500
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
> > >
> > > In order to move enabling of trace events to just after mm_init(), the
> > > tracepoint enable code can not use call_rcu_sched() because rcu isn't
> > > even initialized yet. Since this can only happen before SMP is set up
> > > (and even before interrupts are set up), there's no reason to use
> > > call_rcu_sched() at this point.
> > >
> > > Instead, create a variable called tracepoint_rcu_safe that gets enabled
> > > via early_initcall() and if that is not set, free the code directly
> > > instead of using call_rcu_sched().
> > >
> > > This allows us to enable tracepoints early without issues.
> > >
> > > Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> > > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> With the addition of read_mostly, and given that I am not going to mess
> with call_rcu() this late in the 3.19 process without a blazingly good
> reason:
>
> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Thanks!
>
> Please note that you can use call_rcu() and friends as soon as rcu_init()
> returns. The callbacks won't be invoked until early_initcall() time,
> but they will be properly queued.
>
> Please note also that there are places where turning a call_rcu() into
> a direct function call don't work, even at times when preemption is
> disabled and there is only one CPU. One example is where single-threaded
> code uses call_rcu() on a list element of a list that it is traversing
> within an RCU read-side critical section. A direct call to the RCU
> callback could potentially destroy the pointers that the traversal was
> going to use to find the next element. This means that we cannot make
> call_rcu() do direct calls to the callback, as that would break quite
> a bit of existing code.
>
> Is there some definite point during boot before which you won't need to
> invoke call_rcu_sched() for tracing? I am guessing "no", but have to ask.
> I can probably make call_rcu_sched() work arbitrarily early, but it is a
> bit uglier. And this assumes that irqs_disabled_flags(local_irq_save())
> returns true during early boot. I would -hope- this would be true! ;-)
>
With your feed back, and because I would like this to go into 3.19, I
would like to keep the current patch as is (with the read_mostly
update, which I'm currently testing). We can always change it later
after call_rcu() has been changed.
-- Steve
next prev parent reply other threads:[~2014-12-14 18:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 16:41 [PATCH 0/3] tracing: Enable tracepoints early and allow printk to use them Steven Rostedt
2014-12-14 16:41 ` [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall() Steven Rostedt
2014-12-14 16:53 ` Steven Rostedt
2014-12-14 18:08 ` Paul E. McKenney
2014-12-14 18:15 ` Steven Rostedt [this message]
2014-12-14 18:18 ` Paul E. McKenney
2014-12-14 18:25 ` Steven Rostedt
2014-12-14 20:23 ` Paul E. McKenney
2014-12-14 17:05 ` Mathieu Desnoyers
2014-12-14 17:14 ` Steven Rostedt
2014-12-14 17:21 ` Steven Rostedt
2014-12-14 17:29 ` Mathieu Desnoyers
2014-12-14 17:44 ` Steven Rostedt
2014-12-14 18:13 ` Paul E. McKenney
2014-12-14 16:41 ` [PATCH 2/3] tracing: Move enabling tracepoints to just after mm_init() Steven Rostedt
2014-12-14 18:14 ` Paul E. McKenney
2014-12-14 18:20 ` Steven Rostedt
2014-12-14 20:26 ` Paul E. McKenney
2014-12-14 16:41 ` [PATCH 3/3] tracing: Add tp_printk cmdline to have tracepoints go to printk() Steven Rostedt
2014-12-14 17:07 ` [PATCH 0/3] tracing: Enable tracepoints early and allow printk to use them Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141214131538.7a6c1438@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).