* [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
@ 2014-12-15 20:37 Evgeni Dobrev
2014-12-16 8:19 ` Andrew Lunn
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Evgeni Dobrev @ 2014-12-15 20:37 UTC (permalink / raw)
To: devicetree; +Cc: linux-kernel, linux-arm-kernel
This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Signed-off-by: Evgeni Dobrev <evgeni@studio-punkt.com>
---
arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
index dd81508..bed2dec 100644
--- a/arch/arm/boot/dts/kirkwood-6192.dtsi
+++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
@@ -66,6 +66,8 @@
interrupts = <21>;
clocks = <&gate_clk 14>, <&gate_clk 15>;
clock-names = "0", "1";
+ phys = <&sata_phy0>, <&sata_phy1>;
+ phy-names = "port0", "port1";
status = "disabled";
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
2014-12-15 20:37 [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192 Evgeni Dobrev
@ 2014-12-16 8:19 ` Andrew Lunn
2014-12-16 13:46 ` Sergei Shtylyov
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2014-12-16 8:19 UTC (permalink / raw)
To: Evgeni Dobrev
Cc: devicetree, linux-kernel, linux-arm-kernel, Jason Cooper,
Sebastian Hesselbarth, Gregory Clement
On Mon, Dec 15, 2014 at 09:37:24PM +0100, Evgeni Dobrev wrote:
> This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
>
> Signed-off-by: Evgeni Dobrev <evgeni@studio-punkt.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
This should also go to stable.
Andrew
> ---
> arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
> index dd81508..bed2dec 100644
> --- a/arch/arm/boot/dts/kirkwood-6192.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
> @@ -66,6 +66,8 @@
> interrupts = <21>;
> clocks = <&gate_clk 14>, <&gate_clk 15>;
> clock-names = "0", "1";
> + phys = <&sata_phy0>, <&sata_phy1>;
> + phy-names = "port0", "port1";
> status = "disabled";
> };
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
2014-12-15 20:37 [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192 Evgeni Dobrev
2014-12-16 8:19 ` Andrew Lunn
@ 2014-12-16 13:46 ` Sergei Shtylyov
2014-12-16 16:01 ` Thomas Petazzoni
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2014-12-16 13:46 UTC (permalink / raw)
To: Evgeni Dobrev, devicetree; +Cc: linux-kernel, linux-arm-kernel
Hello.
On 12/15/2014 11:37 PM, Evgeni Dobrev wrote:
> This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Please wrap the change log likes at 80 characters or less.
> Signed-off-by: Evgeni Dobrev <evgeni@studio-punkt.com>
> ---
> arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
> index dd81508..bed2dec 100644
> --- a/arch/arm/boot/dts/kirkwood-6192.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
> @@ -66,6 +66,8 @@
> interrupts = <21>;
> clocks = <&gate_clk 14>, <&gate_clk 15>;
> clock-names = "0", "1";
> + phys = <&sata_phy0>, <&sata_phy1>;
> + phy-names = "port0", "port1";
Please indent with tabs, not spaces.
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
2014-12-15 20:37 [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192 Evgeni Dobrev
2014-12-16 8:19 ` Andrew Lunn
2014-12-16 13:46 ` Sergei Shtylyov
@ 2014-12-16 16:01 ` Thomas Petazzoni
2014-12-16 18:19 ` Evgeni Dobrev
2014-12-16 18:21 ` [PATCH v2 0/1] " Evgeni Dobrev
2014-12-16 18:22 ` [PATCH v2 1/1] " Evgeni Dobrev
4 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2014-12-16 16:01 UTC (permalink / raw)
To: Evgeni Dobrev; +Cc: devicetree, linux-kernel, linux-arm-kernel
Dear Evgeni Dobrev,
On Mon, 15 Dec 2014 21:37:24 +0100, Evgeni Dobrev wrote:
> This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Commit log text should be wrapped to some reasonable length.
> interrupts = <21>;
> clocks = <&gate_clk 14>, <&gate_clk 15>;
> clock-names = "0", "1";
> + phys = <&sata_phy0>, <&sata_phy1>;
> + phy-names = "port0", "port1";
You should use tabs and not spaces for indentation in Device Tree files.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
2014-12-16 16:01 ` Thomas Petazzoni
@ 2014-12-16 18:19 ` Evgeni Dobrev
0 siblings, 0 replies; 8+ messages in thread
From: Evgeni Dobrev @ 2014-12-16 18:19 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: devicetree, linux-kernel, linux-arm-kernel
Hello Thomas,
On Tue, Dec 16, 2014 at 05:01:38PM +0100, Thomas Petazzoni wrote:
> Dear Evgeni Dobrev,
>
> On Mon, 15 Dec 2014 21:37:24 +0100, Evgeni Dobrev wrote:
> > This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
>
> Commit log text should be wrapped to some reasonable length.
>
I will fix this.
>
> > interrupts = <21>;
> > clocks = <&gate_clk 14>, <&gate_clk 15>;
> > clock-names = "0", "1";
> > + phys = <&sata_phy0>, <&sata_phy1>;
> > + phy-names = "port0", "port1";
>
> You should use tabs and not spaces for indentation in Device Tree files.
I will resubmit. Thank you for your review.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> --
evgeni
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 0/1] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
2014-12-15 20:37 [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192 Evgeni Dobrev
` (2 preceding siblings ...)
2014-12-16 16:01 ` Thomas Petazzoni
@ 2014-12-16 18:21 ` Evgeni Dobrev
2014-12-16 18:22 ` [PATCH v2 1/1] " Evgeni Dobrev
4 siblings, 0 replies; 8+ messages in thread
From: Evgeni Dobrev @ 2014-12-16 18:21 UTC (permalink / raw)
To: devicetree
Cc: linux-kernel, linux-arm-kernel, Jason Cooper,
Sebastian Hesselbarth, Gregory Clement
v2: indent with tabs only
wrap change log at 80 chars
Evgeni Dobrev (1):
enable phy driver for SATA controller on 88f6192
arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
1 file changed, 2 insertions(+)
--
1.7.10.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/1] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
2014-12-15 20:37 [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192 Evgeni Dobrev
` (3 preceding siblings ...)
2014-12-16 18:21 ` [PATCH v2 0/1] " Evgeni Dobrev
@ 2014-12-16 18:22 ` Evgeni Dobrev
2014-12-21 12:43 ` Andrew Lunn
4 siblings, 1 reply; 8+ messages in thread
From: Evgeni Dobrev @ 2014-12-16 18:22 UTC (permalink / raw)
To: devicetree
Cc: linux-kernel, linux-arm-kernel, Jason Cooper,
Sebastian Hesselbarth, Gregory Clement
This patch enables the phy drivers for the SATA controller on Marvell's 88f6192.
Without them it is not possible to use SATA drives attached to this processor.
Signed-off-by: Evgeni Dobrev <evgeni@studio-punkt.com>
---
arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
index dd81508..9e6e9e2 100644
--- a/arch/arm/boot/dts/kirkwood-6192.dtsi
+++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
@@ -66,6 +66,8 @@
interrupts = <21>;
clocks = <&gate_clk 14>, <&gate_clk 15>;
clock-names = "0", "1";
+ phys = <&sata_phy0>, <&sata_phy1>;
+ phy-names = "port0", "port1";
status = "disabled";
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
2014-12-16 18:22 ` [PATCH v2 1/1] " Evgeni Dobrev
@ 2014-12-21 12:43 ` Andrew Lunn
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Lunn @ 2014-12-21 12:43 UTC (permalink / raw)
To: Evgeni Dobrev
Cc: devicetree, Gregory Clement, Sebastian Hesselbarth, linux-kernel,
linux-arm-kernel, Jason Cooper
On Tue, Dec 16, 2014 at 07:22:18PM +0100, Evgeni Dobrev wrote:
> This patch enables the phy drivers for the SATA controller on Marvell's 88f6192.
> Without them it is not possible to use SATA drives attached to this processor.
>
> Signed-off-by: Evgeni Dobrev <evgeni@studio-punkt.com>
Hi Evgeni
Added to mvebu/dt
Andrew
> ---
> arch/arm/boot/dts/kirkwood-6192.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-6192.dtsi b/arch/arm/boot/dts/kirkwood-6192.dtsi
> index dd81508..9e6e9e2 100644
> --- a/arch/arm/boot/dts/kirkwood-6192.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-6192.dtsi
> @@ -66,6 +66,8 @@
> interrupts = <21>;
> clocks = <&gate_clk 14>, <&gate_clk 15>;
> clock-names = "0", "1";
> + phys = <&sata_phy0>, <&sata_phy1>;
> + phy-names = "port0", "port1";
> status = "disabled";
> };
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-12-21 12:45 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-15 20:37 [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192 Evgeni Dobrev
2014-12-16 8:19 ` Andrew Lunn
2014-12-16 13:46 ` Sergei Shtylyov
2014-12-16 16:01 ` Thomas Petazzoni
2014-12-16 18:19 ` Evgeni Dobrev
2014-12-16 18:21 ` [PATCH v2 0/1] " Evgeni Dobrev
2014-12-16 18:22 ` [PATCH v2 1/1] " Evgeni Dobrev
2014-12-21 12:43 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).