* [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c
@ 2014-12-18 16:46 Robert Nachlinger
2014-12-18 16:52 ` Greg KH
2014-12-19 22:58 ` Greg KH
0 siblings, 2 replies; 8+ messages in thread
From: Robert Nachlinger @ 2014-12-18 16:46 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Robert Nachlinger
This is a patch to the gdm_mux.c file that fixes a space before comma coding style issue found by the checkpatch.pl tool.
Signed-off-by: Robert Nachlinger <robert.nachlinger@googlemail.com>
---
drivers/staging/gdm724x/gdm_mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index b5b063a..d1ab996 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
static void do_rx(struct work_struct *work)
{
struct mux_dev *mux_dev =
- container_of(work, struct mux_dev , work_rx.work);
+ container_of(work, struct mux_dev, work_rx.work);
struct mux_rx *r;
struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
unsigned long flags;
--
2.2.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c
2014-12-18 16:46 [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c Robert Nachlinger
@ 2014-12-18 16:52 ` Greg KH
2014-12-19 22:58 ` Greg KH
1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2014-12-18 16:52 UTC (permalink / raw)
To: Robert Nachlinger; +Cc: devel, Robert Nachlinger, linux-kernel
On Thu, Dec 18, 2014 at 05:46:29PM +0100, Robert Nachlinger wrote:
> This is a patch to the gdm_mux.c file that fixes a space before comma coding style issue found by the checkpatch.pl tool.
Please line-wrap your changelog text, there's no reason to have lines
this long, right?
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c
2014-12-18 16:46 [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c Robert Nachlinger
2014-12-18 16:52 ` Greg KH
@ 2014-12-19 22:58 ` Greg KH
[not found] ` <CABdSh179apawgBKm9=2vBaxVBPTemz4SPhDcgf_2kwk7rsn2oA@mail.gmail.com>
1 sibling, 1 reply; 8+ messages in thread
From: Greg KH @ 2014-12-19 22:58 UTC (permalink / raw)
To: Robert Nachlinger; +Cc: devel, linux-kernel, Robert Nachlinger
On Thu, Dec 18, 2014 at 05:46:29PM +0100, Robert Nachlinger wrote:
> This is a patch to the gdm_mux.c file that fixes a space before comma coding style issue found by the checkpatch.pl tool.
Can you fix up your line to be line-wrapped at 72 columns so I don't
have to do it by hand?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c
[not found] ` <CABdSh179apawgBKm9=2vBaxVBPTemz4SPhDcgf_2kwk7rsn2oA@mail.gmail.com>
@ 2014-12-20 17:12 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2014-12-20 17:12 UTC (permalink / raw)
To: Robert N; +Cc: devel, linux-kernel, Robert Nachlinger
On Sat, Dec 20, 2014 at 12:51:00PM +0100, Robert N wrote:
> I already sent you the patch line-wrapped at column 69, so it says:
>
> > This is a patch to the gdm_mux.c file that fixes a space before comma
> > coding style issue found by the checkpatch.pl tool.
>
> Do i have to wrap it exactly at column 72? That would break a word:
>
> > This is a patch to the gdm_mux.c file that fixes a space before comma co
> > ding style issue found by the checkpatch.pl tool.
Of course not, use a "sane" editor that wraps at a word boundry please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c
2014-12-21 10:44 Robert Nachlinger
@ 2015-01-17 22:57 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2015-01-17 22:57 UTC (permalink / raw)
To: Robert Nachlinger; +Cc: devel, linux-kernel
On Sun, Dec 21, 2014 at 11:44:43AM +0100, Robert Nachlinger wrote:
> This is a patch to the gdm_mux.c file that fixes a space before comma
> coding style issue found by the checkpatch.pl tool.
>
> Signed-off-by: Robert Nachlinger <robert.nachlinger@googlemail.com>
> ---
> drivers/staging/gdm724x/gdm_mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
> index b5b063a..d1ab996 100644
> --- a/drivers/staging/gdm724x/gdm_mux.c
> +++ b/drivers/staging/gdm724x/gdm_mux.c
> @@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
> static void do_rx(struct work_struct *work)
> {
> struct mux_dev *mux_dev =
> - container_of(work, struct mux_dev , work_rx.work);
> + container_of(work, struct mux_dev, work_rx.work);
> struct mux_rx *r;
> struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
> unsigned long flags;
> --
> 2.2.0
Someone else sent this same patch :(
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c
@ 2014-12-21 10:44 Robert Nachlinger
2015-01-17 22:57 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Robert Nachlinger @ 2014-12-21 10:44 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Robert Nachlinger
This is a patch to the gdm_mux.c file that fixes a space before comma
coding style issue found by the checkpatch.pl tool.
Signed-off-by: Robert Nachlinger <robert.nachlinger@googlemail.com>
---
drivers/staging/gdm724x/gdm_mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index b5b063a..d1ab996 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
static void do_rx(struct work_struct *work)
{
struct mux_dev *mux_dev =
- container_of(work, struct mux_dev , work_rx.work);
+ container_of(work, struct mux_dev, work_rx.work);
struct mux_rx *r;
struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
unsigned long flags;
--
2.2.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c
@ 2014-12-18 16:57 Robert Nachlinger
0 siblings, 0 replies; 8+ messages in thread
From: Robert Nachlinger @ 2014-12-18 16:57 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Robert Nachlinger
This is a patch to the gdm_mux.c file that fixes a space before comma
coding style issue found by the checkpatch.pl tool.
Signed-off-by: Robert Nachlinger <robert.nachlinger@googlemail.com>
---
drivers/staging/gdm724x/gdm_mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index b5b063a..d1ab996 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
static void do_rx(struct work_struct *work)
{
struct mux_dev *mux_dev =
- container_of(work, struct mux_dev , work_rx.work);
+ container_of(work, struct mux_dev, work_rx.work);
struct mux_rx *r;
struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
unsigned long flags;
--
2.2.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c
@ 2014-12-18 14:09 Robert Nachlinger
0 siblings, 0 replies; 8+ messages in thread
From: Robert Nachlinger @ 2014-12-18 14:09 UTC (permalink / raw)
To: gregkh
Cc: daniel.dy.ngu, josh, gulsah.1004, devel, linux-kernel, Robert Nachlinger
diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index b5b063a..d1ab996 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)
static void do_rx(struct work_struct *work)
{
struct mux_dev *mux_dev =
- container_of(work, struct mux_dev , work_rx.work);
+ container_of(work, struct mux_dev, work_rx.work);
struct mux_rx *r;
struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;
unsigned long flags;
--
2.2.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-01-17 23:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-18 16:46 [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c Robert Nachlinger
2014-12-18 16:52 ` Greg KH
2014-12-19 22:58 ` Greg KH
[not found] ` <CABdSh179apawgBKm9=2vBaxVBPTemz4SPhDcgf_2kwk7rsn2oA@mail.gmail.com>
2014-12-20 17:12 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-12-21 10:44 Robert Nachlinger
2015-01-17 22:57 ` Greg KH
2014-12-18 16:57 Robert Nachlinger
2014-12-18 14:09 Robert Nachlinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).