[PATCH] crypto: omap-des: fix BUG_ON condition

[PATCH] crypto: omap-des: fix BUG_ON condition

[Asaf Vertz]

dd->total is unsigned so it won't do any good to check for negative value after subtracting
instead of that we should check if the subtracted value is bigger than him

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
---
 drivers/crypto/omap-des.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index e350f5b..0b8dcf5 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -965,9 +965,9 @@ static irqreturn_t omap_des_irq(int irq, void *dev_id)
 			}
 		}
 
-		dd->total -= DES_BLOCK_SIZE;
+		BUG_ON(dd->total < DES_BLOCK_SIZE);
 
-		BUG_ON(dd->total < 0);
+		dd->total -= DES_BLOCK_SIZE;
 
 		/* Clear IRQ status */
 		status &= ~DES_REG_IRQ_DATA_OUT;
-- 
1.7.0.4

Re: [PATCH] crypto: omap-des: fix BUG_ON condition

[Herbert Xu]

On Mon, Jan 05, 2015 at 10:23:10AM +0200, Asaf Vertz wrote:
> dd->total is unsigned so it won't do any good to check for negative value after subtracting
> instead of that we should check if the subtracted value is bigger than him
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>

Applied.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt