* [PATCH v2] PCI/sysfs: off by two when checking the limit on driver_override length
@ 2015-01-07 20:52 Sasha Levin
2015-01-07 21:03 ` Alex Williamson
2015-01-10 15:31 ` Bjorn Helgaas
0 siblings, 2 replies; 3+ messages in thread
From: Sasha Levin @ 2015-01-07 20:52 UTC (permalink / raw)
To: linux-kernel
Cc: Sasha Levin, stable, Alex Williamson, Bjorn Helgaas,
Konrad Rzeszutek Wilk, Alexander Graf, Greg Kroah-Hartman,
open list:PCI SUBSYSTEM
When printing the driver_override parameter when it is 4095 and 4094 bytes
long the printing code would access invalid memory because we need count+1
bytes for printing.
Cc: <stable@vger.kernel.org> # v3.16+
Fixes: 782a985d ("PCI: Introduce new device binding path using pci_dev.driver_override")
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Alexander Graf <agraf@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
drivers/pci/pci-sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index aa012fb..17459ed 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -521,7 +521,8 @@ static ssize_t driver_override_store(struct device *dev,
struct pci_dev *pdev = to_pci_dev(dev);
char *driver_override, *old = pdev->driver_override, *cp;
- if (count > PATH_MAX)
+ /* We need to keep extra room for a newline */
+ if (count >= (PATH_MAX - 1))
return -EINVAL;
driver_override = kstrndup(buf, count, GFP_KERNEL);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PCI/sysfs: off by two when checking the limit on driver_override length
2015-01-07 20:52 [PATCH v2] PCI/sysfs: off by two when checking the limit on driver_override length Sasha Levin
@ 2015-01-07 21:03 ` Alex Williamson
2015-01-10 15:31 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2015-01-07 21:03 UTC (permalink / raw)
To: Sasha Levin
Cc: linux-kernel, stable, Bjorn Helgaas, Konrad Rzeszutek Wilk,
Alexander Graf, Greg Kroah-Hartman, open list:PCI SUBSYSTEM
On Wed, 2015-01-07 at 15:52 -0500, Sasha Levin wrote:
> When printing the driver_override parameter when it is 4095 and 4094 bytes
> long the printing code would access invalid memory because we need count+1
> bytes for printing.
>
> Cc: <stable@vger.kernel.org> # v3.16+
> Fixes: 782a985d ("PCI: Introduce new device binding path using pci_dev.driver_override")
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
> drivers/pci/pci-sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index aa012fb..17459ed 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -521,7 +521,8 @@ static ssize_t driver_override_store(struct device *dev,
> struct pci_dev *pdev = to_pci_dev(dev);
> char *driver_override, *old = pdev->driver_override, *cp;
>
> - if (count > PATH_MAX)
> + /* We need to keep extra room for a newline */
> + if (count >= (PATH_MAX - 1))
> return -EINVAL;
>
> driver_override = kstrndup(buf, count, GFP_KERNEL);
Thanks for posting this Sasha, it fell off my plate with other
activities.
Acked-by: Alex Williamson <alex.williamson@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] PCI/sysfs: off by two when checking the limit on driver_override length
2015-01-07 20:52 [PATCH v2] PCI/sysfs: off by two when checking the limit on driver_override length Sasha Levin
2015-01-07 21:03 ` Alex Williamson
@ 2015-01-10 15:31 ` Bjorn Helgaas
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2015-01-10 15:31 UTC (permalink / raw)
To: Sasha Levin
Cc: linux-kernel, stable, Alex Williamson, Konrad Rzeszutek Wilk,
Alexander Graf, Greg Kroah-Hartman, open list:PCI SUBSYSTEM,
Kim Phillips, Stuart Yoder
[+cc Kim, Stuart]
On Wed, Jan 07, 2015 at 03:52:57PM -0500, Sasha Levin wrote:
> When printing the driver_override parameter when it is 4095 and 4094 bytes
> long the printing code would access invalid memory because we need count+1
> bytes for printing.
Hi Sasha,
I swear I'm not trying to be a nuisance, but wasn't there another fix for a
different memory corruption problem? I was expecting two patches, but I
only see one.
If I understand this right, the problem is that driver_override_show() adds
"\n" at the end of the driver name, and the whole string (driver name +
newline) must fit within a page because sysfs show functions only have a
page to put their data in.
So the buffer overrun is in driver_override_show(), but the proposed fix is
in driver_override_store(). I think that's too complicated. I'd rather
use snprintf(..., PAGE_SIZE, ...) in driver_override_show() because that's
a common pattern and it's easy to verify that it's correct.
I don't think it's worth it to validate the length in
driver_override_store(). I think the pattern in resume_store() should be
sufficient, e.g.,
if (count && buf[count - 1] == '\n')
count--;
name = kstrndup(buf, count, GFP_KERNEL);
if (!name)
return -ENOMEM;
pdev->driver_override = name;
kfree(old);
If a user sets a driver name that's 4KB long, and the output of
driver_override_show() is truncated, that doesn't seem like a real issue.
driver_override_store()/driver_override_show() in drivers/base/platform.c
(added by 3d713e0e382e ("driver core: platform: add device binding path
'driver_override'")) is basically the same code, and it looks like it has
the same two problems. Can you add fix those at the same time?
Bjorn
> Cc: <stable@vger.kernel.org> # v3.16+
> Fixes: 782a985d ("PCI: Introduce new device binding path using pci_dev.driver_override")
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
> drivers/pci/pci-sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index aa012fb..17459ed 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -521,7 +521,8 @@ static ssize_t driver_override_store(struct device *dev,
> struct pci_dev *pdev = to_pci_dev(dev);
> char *driver_override, *old = pdev->driver_override, *cp;
>
> - if (count > PATH_MAX)
> + /* We need to keep extra room for a newline */
> + if (count >= (PATH_MAX - 1))
> return -EINVAL;
>
> driver_override = kstrndup(buf, count, GFP_KERNEL);
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-10 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-07 20:52 [PATCH v2] PCI/sysfs: off by two when checking the limit on driver_override length Sasha Levin
2015-01-07 21:03 ` Alex Williamson
2015-01-10 15:31 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).