linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] fujitsu-laptop: use FB_BLANK_* constants
       [not found] <0150118191421.GJ56582@vmdeb7>
@ 2015-01-18 19:28 ` Michael Karcher
  2015-01-18 22:22   ` Darren Hart
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Karcher @ 2015-01-18 19:28 UTC (permalink / raw)
  To: Jonathan Woithe, Darren Hart, platform-driver-x86, linux-kernel

Replace the magic numbers in fujitsu-laptop.c by the appropriate FB_BLANK
constants, as indicated by the comment for backlight_properties.power in
include/linux/backlight.h.

Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
---
 drivers/platform/x86/fujitsu-laptop.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 7c21c1c..2a9afa2 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -64,6 +64,7 @@
 #include <linux/acpi.h>
 #include <linux/dmi.h>
 #include <linux/backlight.h>
+#include <linux/fb.h>
 #include <linux/input.h>
 #include <linux/kfifo.h>
 #include <linux/platform_device.h>
@@ -398,7 +399,7 @@ static int bl_get_brightness(struct backlight_device *b)
 static int bl_update_status(struct backlight_device *b)
 {
 	int ret;
-	if (b->props.power == 4)
+	if (b->props.power == FB_BLANK_POWERDOWN)
 		ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x3);
 	else
 		ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x0);
@@ -1139,9 +1140,9 @@ static int __init fujitsu_init(void)
 
 	if (!acpi_video_backlight_support()) {
 		if (call_fext_func(FUNC_BACKLIGHT, 0x2, 0x4, 0x0) == 3)
-			fujitsu->bl_device->props.power = 4;
+			fujitsu->bl_device->props.power = FB_BLANK_POWERDOWN;
 		else
-			fujitsu->bl_device->props.power = 0;
+			fujitsu->bl_device->props.power = FB_BLANK_UNBLANK;
 	}
 
 	pr_info("driver " FUJITSU_DRIVER_VERSION " successfully loaded\n");
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] fujitsu-laptop: use FB_BLANK_* constants
  2015-01-18 19:28 ` [PATCH 1/1] fujitsu-laptop: use FB_BLANK_* constants Michael Karcher
@ 2015-01-18 22:22   ` Darren Hart
  2015-01-19  0:03     ` Jonathan Woithe
  0 siblings, 1 reply; 4+ messages in thread
From: Darren Hart @ 2015-01-18 22:22 UTC (permalink / raw)
  To: Michael Karcher; +Cc: Jonathan Woithe, platform-driver-x86, linux-kernel

On Sun, Jan 18, 2015 at 08:28:46PM +0100, Michael Karcher wrote:
> Replace the magic numbers in fujitsu-laptop.c by the appropriate FB_BLANK
> constants, as indicated by the comment for backlight_properties.power in
> include/linux/backlight.h.
> 
> Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>

Thanks Michael, queued for 3.20.

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] fujitsu-laptop: use FB_BLANK_* constants
  2015-01-18 22:22   ` Darren Hart
@ 2015-01-19  0:03     ` Jonathan Woithe
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Woithe @ 2015-01-19  0:03 UTC (permalink / raw)
  To: Darren Hart; +Cc: Michael Karcher, platform-driver-x86, linux-kernel

On Sun, Jan 18, 2015 at 02:22:32PM -0800, Darren Hart wrote:
> On Sun, Jan 18, 2015 at 08:28:46PM +0100, Michael Karcher wrote:
> > Replace the magic numbers in fujitsu-laptop.c by the appropriate FB_BLANK
> > constants, as indicated by the comment for backlight_properties.power in
> > include/linux/backlight.h.
> > 
> > Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
> 
> Thanks Michael, queued for 3.20.

Acked-by: Jonathan Woithe <jwoithe@just42.net>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH 1/1] fujitsu-laptop: use FB_BLANK_* constants
@ 2015-01-17 23:32 Michael Karcher
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Karcher @ 2015-01-17 23:32 UTC (permalink / raw)
  To: Jonathan Woithe, Darren Hart, platform-driver-x86, linux-kernel
  Cc: Michael Karcher

From: Michael Karcher <karcher@physik.fu-berlin.de>

---
 drivers/platform/x86/fujitsu-laptop.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 7c21c1c..2a9afa2 100644
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -64,6 +64,7 @@
 #include <linux/acpi.h>
 #include <linux/dmi.h>
 #include <linux/backlight.h>
+#include <linux/fb.h>
 #include <linux/input.h>
 #include <linux/kfifo.h>
 #include <linux/platform_device.h>
@@ -398,7 +399,7 @@ static int bl_get_brightness(struct backlight_device *b)
 static int bl_update_status(struct backlight_device *b)
 {
 	int ret;
-	if (b->props.power == 4)
+	if (b->props.power == FB_BLANK_POWERDOWN)
 		ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x3);
 	else
 		ret = call_fext_func(FUNC_BACKLIGHT, 0x1, 0x4, 0x0);
@@ -1139,9 +1140,9 @@ static int __init fujitsu_init(void)
 
 	if (!acpi_video_backlight_support()) {
 		if (call_fext_func(FUNC_BACKLIGHT, 0x2, 0x4, 0x0) == 3)
-			fujitsu->bl_device->props.power = 4;
+			fujitsu->bl_device->props.power = FB_BLANK_POWERDOWN;
 		else
-			fujitsu->bl_device->props.power = 0;
+			fujitsu->bl_device->props.power = FB_BLANK_UNBLANK;
 	}
 
 	pr_info("driver " FUJITSU_DRIVER_VERSION " successfully loaded\n");
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-19  0:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <0150118191421.GJ56582@vmdeb7>
2015-01-18 19:28 ` [PATCH 1/1] fujitsu-laptop: use FB_BLANK_* constants Michael Karcher
2015-01-18 22:22   ` Darren Hart
2015-01-19  0:03     ` Jonathan Woithe
2015-01-17 23:32 Michael Karcher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).