From: Sebastian Reichel <sre@kernel.org>
To: Jonghwa Lee <jonghwa3.lee@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
dbaryshkov@gmail.com, dwmw2@infradead.org, anton@enomsg.org,
pavel@ucw.cz, myungjoo.ham@samsung.com, cw00.choi@samsung.com
Subject: Re: [PATCH V3 02/11] power: charger-manager: Use thermal subsystem interface only to get temperature.
Date: Wed, 21 Jan 2015 23:38:48 +0100 [thread overview]
Message-ID: <20150121223848.GI13715@earth.universe> (raw)
In-Reply-To: <1418979323-7188-3-git-send-email-jonghwa3.lee@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
Hi Jonghwa,
On Fri, Dec 19, 2014 at 05:55:14PM +0900, Jonghwa Lee wrote:
> It drops the way of using power_supply interface to reference battery's
> temperature. Then it tries to use thermal subsystem's only. This makes driver
> more simple and also can remove ifdeferies.
this breaks allmodconfig, since CONFIG_THERMAL can be built as
module and charger-manager will be builtin:
drivers/built-in.o: In function `cm_get_battery_temperature.isra.4':
binder.c:(.text+0x2f4008): undefined reference to `thermal_zone_get_temp'
drivers/built-in.o: In function `charger_manager_probe':
binder.c:(.text+0x2f62c4): undefined reference to `thermal_zone_get_zone_by_name'
Makefile:917: recipe for target 'vmlinux' failed
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-21 22:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 8:55 [PATCH V3 0/11] Improve charger manager driver for optimized operation Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 01/11] power: charger-manager: Use alarmtimer for battery monitoring in suspend Jonghwa Lee
2014-12-20 0:21 ` Pavel Machek
2015-01-21 20:44 ` Sebastian Reichel
2014-12-19 8:55 ` [PATCH V3 02/11] power: charger-manager: Use thermal subsystem interface only to get temperature Jonghwa Lee
2015-01-21 22:38 ` Sebastian Reichel [this message]
2014-12-19 8:55 ` [PATCH V3 03/11] power: charger-manager: Use power_supply_changed() not private uevent Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 04/11] power: charger-manager: Remove deprecated function, cm_notify_event() Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 05/11] power: charger-manager: Fix to use CHARGE_NOW/FULL property correctly Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 06/11] power: charger-manager: Concentrate scattered power_supply_changed() calls Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 07/11] power: charger-manager: Get external power souce information only from EXTCON Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 08/11] power: charger-manager: Make chraging decision focusing on battery status Jonghwa Lee
2014-12-20 0:24 ` Pavel Machek
2014-12-22 2:10 ` jonghwa3.lee
2014-12-19 8:55 ` [PATCH V3 09/11] power: charger-manager: Not to start charging directly in cable nofitication Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 10/11] power: charger-manager: Support different polling mode for sleep state Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 11/11] power: charger-manager: Support to change polling rate in runtime Jonghwa Lee
2014-12-20 0:29 ` Pavel Machek
2014-12-22 1:57 ` jonghwa3.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121223848.GI13715@earth.universe \
--to=sre@kernel.org \
--cc=anton@enomsg.org \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).