From: jonghwa3.lee@samsung.com
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org,
anton@enomsg.org, myungjoo.ham@samsung.com,
cw00.choi@samsung.com
Subject: Re: [PATCH V3 08/11] power: charger-manager: Make chraging decision focusing on battery status.
Date: Mon, 22 Dec 2014 11:10:04 +0900 [thread overview]
Message-ID: <54977D7C.9040307@samsung.com> (raw)
In-Reply-To: <20141220002440.GC1694@amd>
On 2014년 12월 20일 09:24, Pavel Machek wrote:
> Subject: charging.
>
(snip..)
>> --- a/include/linux/power/charger-manager.h
>> +++ b/include/linux/power/charger-manager.h
>> @@ -220,6 +220,7 @@ struct charger_desc {
>> * saved status of battery before entering suspend-to-RAM
>> * @charging_start_time: saved start time of enabling charging
>> * @charging_end_time: saved end time of disabling charging
>> + * @battery_status: Current battery status
>
> "current" for consistency.
>
>> */
>> struct charger_manager {
>> struct list_head entry;
>> @@ -237,6 +238,8 @@ struct charger_manager {
>>
>> u64 charging_start_time;
>> u64 charging_end_time;
>> +
>> + int battery_status;
>> };
>
> Should battery_status be some kind of enum?
Currently, it stores only enum of power_supply class's and it doesn't have
specified type. And also, I didn't want to make additional private enums.
I'd let it to be as it was.
Thanks,
Jonghwa
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
next prev parent reply other threads:[~2014-12-22 2:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 8:55 [PATCH V3 0/11] Improve charger manager driver for optimized operation Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 01/11] power: charger-manager: Use alarmtimer for battery monitoring in suspend Jonghwa Lee
2014-12-20 0:21 ` Pavel Machek
2015-01-21 20:44 ` Sebastian Reichel
2014-12-19 8:55 ` [PATCH V3 02/11] power: charger-manager: Use thermal subsystem interface only to get temperature Jonghwa Lee
2015-01-21 22:38 ` Sebastian Reichel
2014-12-19 8:55 ` [PATCH V3 03/11] power: charger-manager: Use power_supply_changed() not private uevent Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 04/11] power: charger-manager: Remove deprecated function, cm_notify_event() Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 05/11] power: charger-manager: Fix to use CHARGE_NOW/FULL property correctly Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 06/11] power: charger-manager: Concentrate scattered power_supply_changed() calls Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 07/11] power: charger-manager: Get external power souce information only from EXTCON Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 08/11] power: charger-manager: Make chraging decision focusing on battery status Jonghwa Lee
2014-12-20 0:24 ` Pavel Machek
2014-12-22 2:10 ` jonghwa3.lee [this message]
2014-12-19 8:55 ` [PATCH V3 09/11] power: charger-manager: Not to start charging directly in cable nofitication Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 10/11] power: charger-manager: Support different polling mode for sleep state Jonghwa Lee
2014-12-19 8:55 ` [PATCH V3 11/11] power: charger-manager: Support to change polling rate in runtime Jonghwa Lee
2014-12-20 0:29 ` Pavel Machek
2014-12-22 1:57 ` jonghwa3.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54977D7C.9040307@samsung.com \
--to=jonghwa3.lee@samsung.com \
--cc=anton@enomsg.org \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).