* [PATCH] mmc: dw_mmc: rockchip: remove incorrect __exit_p()
@ 2015-01-24 0:30 Dmitry Torokhov
2015-01-26 20:50 ` Doug Anderson
2015-01-27 13:59 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2015-01-24 0:30 UTC (permalink / raw)
To: Ulf Hansson
Cc: Jaehoon Chung, Seungwon Jeon, Heiko Stuebner, Chris Ball,
Doug Anderson, Addy Ke, linux-mmc, linux-rockchip, linux-kernel
dw_mci_pltfm_remove() is not (nor should it be) marked as __exit,
so we should not be using __exit_p() wrapper with it.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index 5650ac4..e2a726a 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -133,7 +133,7 @@ static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
static struct platform_driver dw_mci_rockchip_pltfm_driver = {
.probe = dw_mci_rockchip_probe,
- .remove = __exit_p(dw_mci_pltfm_remove),
+ .remove = dw_mci_pltfm_remove,
.driver = {
.name = "dwmmc_rockchip",
.of_match_table = dw_mci_rockchip_match,
--
2.2.0.rc0.207.ga3a616c
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: rockchip: remove incorrect __exit_p()
2015-01-24 0:30 [PATCH] mmc: dw_mmc: rockchip: remove incorrect __exit_p() Dmitry Torokhov
@ 2015-01-26 20:50 ` Doug Anderson
2015-01-27 13:59 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2015-01-26 20:50 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Ulf Hansson, Jaehoon Chung, Seungwon Jeon, Heiko Stuebner,
Chris Ball, Addy Ke, linux-mmc, open list:ARM/Rockchip SoC...,
linux-kernel
Dmitry,
On Fri, Jan 23, 2015 at 4:30 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> dw_mci_pltfm_remove() is not (nor should it be) marked as __exit,
> so we should not be using __exit_p() wrapper with it.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch, thanks!
Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: rockchip: remove incorrect __exit_p()
2015-01-24 0:30 [PATCH] mmc: dw_mmc: rockchip: remove incorrect __exit_p() Dmitry Torokhov
2015-01-26 20:50 ` Doug Anderson
@ 2015-01-27 13:59 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2015-01-27 13:59 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Jaehoon Chung, Seungwon Jeon, Heiko Stuebner, Chris Ball,
Doug Anderson, Addy Ke, linux-mmc, open list:ARM/Rockchip SoC...,
linux-kernel
On 24 January 2015 at 01:30, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> dw_mci_pltfm_remove() is not (nor should it be) marked as __exit,
> so we should not be using __exit_p() wrapper with it.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks! Applied for next.
Kind regards
Uffe
> ---
> drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index 5650ac4..e2a726a 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -133,7 +133,7 @@ static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
>
> static struct platform_driver dw_mci_rockchip_pltfm_driver = {
> .probe = dw_mci_rockchip_probe,
> - .remove = __exit_p(dw_mci_pltfm_remove),
> + .remove = dw_mci_pltfm_remove,
> .driver = {
> .name = "dwmmc_rockchip",
> .of_match_table = dw_mci_rockchip_match,
> --
> 2.2.0.rc0.207.ga3a616c
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-27 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-24 0:30 [PATCH] mmc: dw_mmc: rockchip: remove incorrect __exit_p() Dmitry Torokhov
2015-01-26 20:50 ` Doug Anderson
2015-01-27 13:59 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).