From: Peter Zijlstra <peterz@infradead.org>
To: Xunlei Pang <pang.xunlei@linaro.org>
Cc: linux-kernel@vger.kernel.org, Juri Lelli <juri.lelli@gmail.com>
Subject: Re: [PATCH 3/5] sched/deadline: Fix wrong cpudl_find() in check_preempt_equal_dl()
Date: Tue, 27 Jan 2015 13:48:15 +0100 [thread overview]
Message-ID: <20150127124815.GC21418@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1421642980-10045-3-git-send-email-pang.xunlei@linaro.org>
On Mon, Jan 19, 2015 at 04:49:38AM +0000, Xunlei Pang wrote:
> +++ b/kernel/sched/deadline.c
> @@ -943,14 +943,23 @@ out:
> return cpu;
> }
>
> +static DEFINE_PER_CPU(cpumask_var_t, local_cpu_mask_dl);
> +
> static void check_preempt_equal_dl(struct rq *rq, struct task_struct *p)
> {
> + struct cpumask *later_mask =
> + this_cpu_cpumask_var_ptr(local_cpu_mask_dl);
> +
> + /* Make sure the mask is initialized first */
> + if (unlikely(!later_mask))
> + return;
> +
> /*
> * Current can't be migrated, useless to reschedule,
> * let's hope p can move out.
> */
> if (rq->curr->nr_cpus_allowed == 1 ||
> - cpudl_find(&rq->rd->cpudl, rq->curr, NULL) == -1)
> + cpudl_find(&rq->rd->cpudl, rq->curr, later_mask) == -1)
> return;
>
> /*
But but, should you not put something in that mask before you use it?
next prev parent reply other threads:[~2015-01-27 12:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 4:49 [PATCH 1/5] sched/deadline: Modify cpudl::free_cpus to reflect rd->online Xunlei Pang
2015-01-19 4:49 ` [PATCH 2/5] sched/deadline: Remove cpu_active_mask from cpudl_find() Xunlei Pang
2015-01-27 15:04 ` Peter Zijlstra
2015-02-04 14:36 ` [tip:sched/core] " tip-bot for Xunlei Pang
2015-01-19 4:49 ` [PATCH 3/5] sched/deadline: Fix wrong cpudl_find() in check_preempt_equal_dl() Xunlei Pang
2015-01-27 12:48 ` Peter Zijlstra [this message]
2015-01-27 14:15 ` Peter Zijlstra
2015-01-27 16:47 ` Peter Zijlstra
2015-01-28 15:18 ` Xunlei Pang
2015-01-19 4:49 ` [PATCH 4/5] sched/rt: Consider deadline tasks in cpupri_find() Xunlei Pang
2015-01-27 12:58 ` Peter Zijlstra
2015-01-27 14:18 ` Peter Zijlstra
2015-01-27 23:04 ` Steven Rostedt
2015-01-28 15:21 ` Xunlei Pang
2015-01-19 4:49 ` [PATCH 5/5] sched/rt: Optimize find_lowest_rq() to select a cache hot cpu Xunlei Pang
2015-01-27 14:21 ` Peter Zijlstra
2015-01-27 14:56 ` Steven Rostedt
2015-01-27 16:28 ` Peter Zijlstra
2015-01-29 16:42 ` Xunlei Pang
2015-01-29 17:17 ` Steven Rostedt
2015-01-29 19:23 ` Peter Zijlstra
2015-02-04 13:07 ` Xunlei Pang
2015-01-23 18:09 ` [PATCH 1/5] sched/deadline: Modify cpudl::free_cpus to reflect rd->online Xunlei Pang
2015-02-01 17:53 ` [tip:sched/core] sched/deadline: Modify cpudl:: free_cpus " tip-bot for Xunlei Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127124815.GC21418@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).