* [PATCH 2/3] ocfs2: removes mlog_errno() call twice in ocfs2_find_dir_space_el()
@ 2015-01-29 10:49 Daeseok Youn
0 siblings, 0 replies; only message in thread
From: Daeseok Youn @ 2015-01-29 10:49 UTC (permalink / raw)
To: mfasheh; +Cc: jlbec, ocfs2-devel, linux-kernel
The mlog_errno() function is called twice when some functions are
failed.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
fs/ocfs2/dir.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
index 940be6d..b08050b 100644
--- a/fs/ocfs2/dir.c
+++ b/fs/ocfs2/dir.c
@@ -3456,10 +3456,8 @@ static int ocfs2_find_dir_space_el(struct inode *dir, const char *name,
int blocksize = dir->i_sb->s_blocksize;
status = ocfs2_read_dir_block(dir, 0, &bh, 0);
- if (status) {
- mlog_errno(status);
+ if (status)
goto bail;
- }
rec_len = OCFS2_DIR_REC_LEN(namelen);
offset = 0;
@@ -3480,10 +3478,9 @@ static int ocfs2_find_dir_space_el(struct inode *dir, const char *name,
status = ocfs2_read_dir_block(dir,
offset >> sb->s_blocksize_bits,
&bh, 0);
- if (status) {
- mlog_errno(status);
+ if (status)
goto bail;
- }
+
/* move to next block */
de = (struct ocfs2_dir_entry *) bh->b_data;
}
--
1.7.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-01-29 10:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 10:49 [PATCH 2/3] ocfs2: removes mlog_errno() call twice in ocfs2_find_dir_space_el() Daeseok Youn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).