linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [dgc-xfs:xfs-ioctl-setattr-cleanup 11/12] fs/xfs/xfs_ioctl.c:1146:1: sparse: symbol 'xfs_ioctl_setattr_check_projid' was not declared. Should it be static?
@ 2015-02-02  7:06 kbuild test robot
  2015-02-02  7:06 ` [PATCH dgc-xfs] xfs: xfs_ioctl_setattr_check_projid can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-02-02  7:06 UTC (permalink / raw)
  To: Dave Chinner; +Cc: kbuild-all, xfs, linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs xfs-ioctl-setattr-cleanup
head:   9b94fcc39822b450af823b3d8cbef6b53ce87ed9
commit: 23bd0735cfdf5322170a9ef48c7d47c2e6567ba8 [11/12] xfs: factor projid hint checking out of xfs_ioctl_setattr
reproduce:
  # apt-get install sparse
  git checkout 23bd0735cfdf5322170a9ef48c7d47c2e6567ba8
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   fs/xfs/xfs_ioctl.c:1102:1: sparse: symbol 'xfs_ioctl_setattr_check_extsize' was not declared. Should it be static?
>> fs/xfs/xfs_ioctl.c:1146:1: sparse: symbol 'xfs_ioctl_setattr_check_projid' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH dgc-xfs] xfs: xfs_ioctl_setattr_check_projid can be static
  2015-02-02  7:06 [dgc-xfs:xfs-ioctl-setattr-cleanup 11/12] fs/xfs/xfs_ioctl.c:1146:1: sparse: symbol 'xfs_ioctl_setattr_check_projid' was not declared. Should it be static? kbuild test robot
@ 2015-02-02  7:06 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-02-02  7:06 UTC (permalink / raw)
  To: Dave Chinner; +Cc: kbuild-all, xfs, linux-kernel

fs/xfs/xfs_ioctl.c:1146:1: sparse: symbol 'xfs_ioctl_setattr_check_projid' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 xfs_ioctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 1f186d2..1060513 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -1142,7 +1142,7 @@ xfs_ioctl_setattr_check_extsize(
 	return 0;
 }
 
-int
+static int
 xfs_ioctl_setattr_check_projid(
 	struct xfs_inode	*ip,
 	struct fsxattr		*fa)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-02  7:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-02  7:06 [dgc-xfs:xfs-ioctl-setattr-cleanup 11/12] fs/xfs/xfs_ioctl.c:1146:1: sparse: symbol 'xfs_ioctl_setattr_check_projid' was not declared. Should it be static? kbuild test robot
2015-02-02  7:06 ` [PATCH dgc-xfs] xfs: xfs_ioctl_setattr_check_projid can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).