From: Mark Brown <broonie@kernel.org>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] spi: mxs: cleanup wait_for_completion return handling
Date: Mon, 2 Feb 2015 12:11:37 +0000 [thread overview]
Message-ID: <20150202121137.GO21293@sirena.org.uk> (raw)
In-Reply-To: <1422865837-10357-2-git-send-email-hofrat@osadl.org>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
On Mon, Feb 02, 2015 at 03:30:33AM -0500, Nicholas Mc Guire wrote:
> - ret = wait_for_completion_timeout(&spi->c,
> - msecs_to_jiffies(SSP_TIMEOUT));
> - if (!ret) {
> + if (!wait_for_completion_timeout(&spi->c,
> + msecs_to_jiffies(SSP_TIMEOUT))) {
Your new indentation is pretty confusing here, I had to look twice to
realize that the msecs_to_jiffies() is still an argument to
wait_for_completion(). Generally arguments to functions should be
aligned with the opening ( for the function, or at least much more
deeply aligned than the function itself (as was the case with the
original code).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-02-02 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 8:30 [PATCH 1/5] spi: match var type to return type of wait_for_completion Nicholas Mc Guire
2015-02-02 8:30 ` [PATCH 2/5] spi: mxs: cleanup wait_for_completion return handling Nicholas Mc Guire
2015-02-02 12:11 ` Mark Brown [this message]
2015-02-02 8:30 ` [PATCH 3/5] spi: sh-msiof: " Nicholas Mc Guire
2015-02-04 20:53 ` Mark Brown
2015-02-02 8:30 ` [PATCH 4/5] spi: spi-imx: cleanup wait_for_completion handling Nicholas Mc Guire
2015-02-04 20:53 ` Mark Brown
2015-02-02 8:30 ` [PATCH 5/5] spi: ti-qspi: cleanup wait_for_completion return handling Nicholas Mc Guire
2015-02-02 12:16 ` Mark Brown
2015-02-04 20:52 ` [PATCH 1/5] spi: match var type to return type of wait_for_completion Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202121137.GO21293@sirena.org.uk \
--to=broonie@kernel.org \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).