* [PATCH] powerpc32: rearrange instructions order in ip_fast_csum()
@ 2015-02-03 11:39 Christophe Leroy
2015-03-25 1:22 ` Scott Wood
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2015-02-03 11:39 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, scottwood
Cc: linux-kernel, linuxppc-dev, Joakim Tjernlund
On PPC_8xx, lwz has a 2 cycles latency, and branching also takes 2 cycles.
As the size of the header is minimum 5 words, we can unroll the loop for the
first words to reduce number of branching, and we can re-order the instructions
to limit loading latency.
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
arch/powerpc/lib/checksum_32.S | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/lib/checksum_32.S b/arch/powerpc/lib/checksum_32.S
index 6d67e05..5500704 100644
--- a/arch/powerpc/lib/checksum_32.S
+++ b/arch/powerpc/lib/checksum_32.S
@@ -26,13 +26,17 @@
_GLOBAL(ip_fast_csum)
lwz r0,0(r3)
lwzu r5,4(r3)
- addic. r4,r4,-2
+ addic. r4,r4,-4
addc r0,r0,r5
mtctr r4
blelr-
-1: lwzu r4,4(r3)
- adde r0,r0,r4
+ lwzu r5,4(r3)
+ lwzu r4,4(r3)
+ adde r0,r0,r5
+1: adde r0,r0,r4
+ lwzu r4,4(r3)
bdnz 1b
+ adde r0,r0,r4
addze r0,r0 /* add in final carry */
rlwinm r3,r0,16,0,31 /* fold two halves together */
add r3,r0,r3
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: powerpc32: rearrange instructions order in ip_fast_csum()
2015-02-03 11:39 [PATCH] powerpc32: rearrange instructions order in ip_fast_csum() Christophe Leroy
@ 2015-03-25 1:22 ` Scott Wood
2015-04-28 19:07 ` christophe leroy
0 siblings, 1 reply; 3+ messages in thread
From: Scott Wood @ 2015-03-25 1:22 UTC (permalink / raw)
To: LEROY Christophe
Cc: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev, linux-kernel
On Tue, Feb 03, 2015 at 12:39:27PM +0100, LEROY Christophe wrote:
> On PPC_8xx, lwz has a 2 cycles latency, and branching also takes 2 cycles.
> As the size of the header is minimum 5 words, we can unroll the loop for the
> first words to reduce number of branching, and we can re-order the instructions
> to limit loading latency.
Please wrap commit messages at around 70 characters.
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/lib/checksum_32.S | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/lib/checksum_32.S b/arch/powerpc/lib/checksum_32.S
> index 6d67e05..5500704 100644
> --- a/arch/powerpc/lib/checksum_32.S
> +++ b/arch/powerpc/lib/checksum_32.S
> @@ -26,13 +26,17 @@
> _GLOBAL(ip_fast_csum)
> lwz r0,0(r3)
> lwzu r5,4(r3)
> - addic. r4,r4,-2
> + addic. r4,r4,-4
> addc r0,r0,r5
> mtctr r4
> blelr-
> -1: lwzu r4,4(r3)
> - adde r0,r0,r4
> + lwzu r5,4(r3)
> + lwzu r4,4(r3)
The blelr is pointless since len is guaranteed to be >= 5 (assuming that
comment is accurate), but now it's both pointless and in the wrong place,
since you haven't yet finished the four words that you subtracted from
r4.
How about keeping the blelr, without the -, moving it after the initial
words, and changing the number of inital words to 5? Also maybe do all
the loads up front, since many PPC chips have a three cycle load latency
rather than two.
-Scott
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: powerpc32: rearrange instructions order in ip_fast_csum()
2015-03-25 1:22 ` Scott Wood
@ 2015-04-28 19:07 ` christophe leroy
0 siblings, 0 replies; 3+ messages in thread
From: christophe leroy @ 2015-04-28 19:07 UTC (permalink / raw)
To: Scott Wood
Cc: Benjamin Herrenschmidt, Paul Mackerras, linuxppc-dev, linux-kernel
Le 25/03/2015 02:22, Scott Wood a écrit :
> On Tue, Feb 03, 2015 at 12:39:27PM +0100, LEROY Christophe wrote:
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>> arch/powerpc/lib/checksum_32.S | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/lib/checksum_32.S b/arch/powerpc/lib/checksum_32.S
>> index 6d67e05..5500704 100644
>> --- a/arch/powerpc/lib/checksum_32.S
>> +++ b/arch/powerpc/lib/checksum_32.S
>> @@ -26,13 +26,17 @@
>> _GLOBAL(ip_fast_csum)
>> lwz r0,0(r3)
>> lwzu r5,4(r3)
>> - addic. r4,r4,-2
>> + addic. r4,r4,-4
>> addc r0,r0,r5
>> mtctr r4
>> blelr-
>> -1: lwzu r4,4(r3)
>> - adde r0,r0,r4
>> + lwzu r5,4(r3)
>> + lwzu r4,4(r3)
> The blelr is pointless since len is guaranteed to be >= 5 (assuming that
> comment is accurate), but now it's both pointless and in the wrong place,
> since you haven't yet finished the four words that you subtracted from
> r4.
The blelr is just there to protect the function against negative value
of r4 hence ctr.
In any case, the returned result in that case in not correct, has we do
not touch r3.
>
> How about keeping the blelr, without the -, moving it after the initial
> words, and changing the number of inital words to 5?
We can't just do blelr, we would need to fold the result first.
But indeed, this would be useless because I quickly checked and it seems
that all functions calling ip_fast_csum()
check that the length is not lower than 5.
So I will just remove the blelr
> Also maybe do all
> the loads up front, since many PPC chips have a three cycle load latency
> rather than two.
ok
Christophe
---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
http://www.avast.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-28 19:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-03 11:39 [PATCH] powerpc32: rearrange instructions order in ip_fast_csum() Christophe Leroy
2015-03-25 1:22 ` Scott Wood
2015-04-28 19:07 ` christophe leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).