linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] spi: imx: use pio mode for i.mx6dl
@ 2015-02-03  2:25 Robin Gong
  2015-02-03 12:18 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Robin Gong @ 2015-02-03  2:25 UTC (permalink / raw)
  To: broonie, l.stach, shawn.guo
  Cc: Frank.Li, Fabio.Estevam, hs, linux-spi, linux-kernel

For TKT238285 hardware issue which may cause txfifo store data twice can only
be caught on i.mx6dl, we use pio mode instead of DMA mode on i.mx6dl.

Signed-off-by: Robin Gong <b38343@freescale.com>
---
 drivers/spi/spi-imx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 961b97d..fe1b769 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -823,6 +823,10 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx,
 	struct dma_slave_config slave_config = {};
 	int ret;
 
+	/* use pio mode for i.mx6dl chip TKT238285 */
+	if (of_machine_is_compatible("fsl,imx6dl"))
+		return 0;
+
 	/* Prepare for TX DMA: */
 	master->dma_tx = dma_request_slave_channel(dev, "tx");
 	if (!master->dma_tx) {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] spi: imx: use pio mode for i.mx6dl
  2015-02-03  2:25 [PATCH v1] spi: imx: use pio mode for i.mx6dl Robin Gong
@ 2015-02-03 12:18 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-02-03 12:18 UTC (permalink / raw)
  To: Robin Gong
  Cc: l.stach, shawn.guo, Frank.Li, Fabio.Estevam, hs, linux-spi, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

On Tue, Feb 03, 2015 at 10:25:53AM +0800, Robin Gong wrote:
> For TKT238285 hardware issue which may cause txfifo store data twice can only
> be caught on i.mx6dl, we use pio mode instead of DMA mode on i.mx6dl.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-03 12:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-03  2:25 [PATCH v1] spi: imx: use pio mode for i.mx6dl Robin Gong
2015-02-03 12:18 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).