* [PATCH] xen-netback: fix sparse warning
@ 2015-02-05 13:38 Lad Prabhakar
2015-02-05 14:01 ` Wei Liu
2015-02-06 0:04 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Lad Prabhakar @ 2015-02-05 13:38 UTC (permalink / raw)
To: Ian Campbell, Wei Liu, xen-devel; +Cc: netdev, linux-kernel, Lad, Prabhakar
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
this patch fixes following sparse warning:
interface.c:83:5: warning: symbol 'xenvif_poll' was not declared. Should it be static?
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
Found this issue on linux-next (gcc version 4.9.2,
sparse version 0.4.5-rc1)and applies on top linux-next.
drivers/net/xen-netback/interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 12f9e27..f38227a 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -80,7 +80,7 @@ static irqreturn_t xenvif_tx_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}
-int xenvif_poll(struct napi_struct *napi, int budget)
+static int xenvif_poll(struct napi_struct *napi, int budget)
{
struct xenvif_queue *queue =
container_of(napi, struct xenvif_queue, napi);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netback: fix sparse warning
2015-02-05 13:38 [PATCH] xen-netback: fix sparse warning Lad Prabhakar
@ 2015-02-05 14:01 ` Wei Liu
2015-02-06 0:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2015-02-05 14:01 UTC (permalink / raw)
To: Lad Prabhakar; +Cc: Ian Campbell, Wei Liu, xen-devel, netdev, linux-kernel
On Thu, Feb 05, 2015 at 01:38:07PM +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warning:
>
> interface.c:83:5: warning: symbol 'xenvif_poll' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Thanks!
> ---
> Found this issue on linux-next (gcc version 4.9.2,
> sparse version 0.4.5-rc1)and applies on top linux-next.
>
> drivers/net/xen-netback/interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index 12f9e27..f38227a 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -80,7 +80,7 @@ static irqreturn_t xenvif_tx_interrupt(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> -int xenvif_poll(struct napi_struct *napi, int budget)
> +static int xenvif_poll(struct napi_struct *napi, int budget)
> {
> struct xenvif_queue *queue =
> container_of(napi, struct xenvif_queue, napi);
> --
> 1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netback: fix sparse warning
2015-02-05 13:38 [PATCH] xen-netback: fix sparse warning Lad Prabhakar
2015-02-05 14:01 ` Wei Liu
@ 2015-02-06 0:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-02-06 0:04 UTC (permalink / raw)
To: prabhakar.csengg; +Cc: ian.campbell, wei.liu2, xen-devel, netdev, linux-kernel
From: Lad Prabhakar <prabhakar.csengg@gmail.com>
Date: Thu, 5 Feb 2015 13:38:07 +0000
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> this patch fixes following sparse warning:
>
> interface.c:83:5: warning: symbol 'xenvif_poll' was not declared. Should it be static?
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-06 0:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 13:38 [PATCH] xen-netback: fix sparse warning Lad Prabhakar
2015-02-05 14:01 ` Wei Liu
2015-02-06 0:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).