* [PATCH] input: elan: Fix wrong %p extension
@ 2015-02-06 13:51 Rasmus Villemoes
2015-02-06 16:40 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2015-02-06 13:51 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Rasmus Villemoes, linux-input, linux-kernel
There's no %px extension. From the context I think the intention was
to dump the five bytes which were not as expected, and for that one
should use %ph.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
I think the bug is mostly harmless, since the unrecognized extension
is simply ignored (and skipped over), and the address of the 'values'
array is simply printed as if by %5p. But since that is an address
on the kernel stack, someone might think it is worse than I do.
drivers/input/mouse/elan_i2c_smbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elan_i2c_smbus.c b/drivers/input/mouse/elan_i2c_smbus.c
index 359bf8583d54..2a89004f3c6e 100644
--- a/drivers/input/mouse/elan_i2c_smbus.c
+++ b/drivers/input/mouse/elan_i2c_smbus.c
@@ -71,7 +71,7 @@ static int elan_smbus_initialize(struct i2c_client *client)
/* compare hello packet */
if (memcmp(values, check, ETP_SMBUS_HELLOPACKET_LEN)) {
- dev_err(&client->dev, "hello packet fail [%*px]\n",
+ dev_err(&client->dev, "hello packet fail [%*ph]\n",
ETP_SMBUS_HELLOPACKET_LEN, values);
return -ENXIO;
}
--
2.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: elan: Fix wrong %p extension
2015-02-06 13:51 [PATCH] input: elan: Fix wrong %p extension Rasmus Villemoes
@ 2015-02-06 16:40 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-02-06 16:40 UTC (permalink / raw)
To: Rasmus Villemoes; +Cc: linux-input, linux-kernel
On Fri, Feb 06, 2015 at 02:51:13PM +0100, Rasmus Villemoes wrote:
> There's no %px extension. From the context I think the intention was
> to dump the five bytes which were not as expected, and for that one
> should use %ph.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Applied, thank you.
> ---
> I think the bug is mostly harmless, since the unrecognized extension
> is simply ignored (and skipped over), and the address of the 'values'
> array is simply printed as if by %5p. But since that is an address
> on the kernel stack, someone might think it is worse than I do.
>
> drivers/input/mouse/elan_i2c_smbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/elan_i2c_smbus.c b/drivers/input/mouse/elan_i2c_smbus.c
> index 359bf8583d54..2a89004f3c6e 100644
> --- a/drivers/input/mouse/elan_i2c_smbus.c
> +++ b/drivers/input/mouse/elan_i2c_smbus.c
> @@ -71,7 +71,7 @@ static int elan_smbus_initialize(struct i2c_client *client)
>
> /* compare hello packet */
> if (memcmp(values, check, ETP_SMBUS_HELLOPACKET_LEN)) {
> - dev_err(&client->dev, "hello packet fail [%*px]\n",
> + dev_err(&client->dev, "hello packet fail [%*ph]\n",
> ETP_SMBUS_HELLOPACKET_LEN, values);
> return -ENXIO;
> }
> --
> 2.1.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-06 16:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-06 13:51 [PATCH] input: elan: Fix wrong %p extension Rasmus Villemoes
2015-02-06 16:40 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).