* [PATCH v2] rtl2832: remove compiler warning
@ 2015-02-11 11:08 Luis de Bethencourt
2015-02-11 13:07 ` Antti Palosaari
2015-02-15 22:46 ` Luis de Bethencourt
0 siblings, 2 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2015-02-11 11:08 UTC (permalink / raw)
To: linux-media; +Cc: mchehab, crop, linux-kernel
Cleaning up the following compiler warning:
rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
tmp, this line would never run because we go to err. It is still nice to avoid
compiler warnings.
Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
---
drivers/media/dvb-frontends/rtl2832.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
index 5d2d8f4..20fa245 100644
--- a/drivers/media/dvb-frontends/rtl2832.c
+++ b/drivers/media/dvb-frontends/rtl2832.c
@@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
struct rtl2832_dev *dev = fe->demodulator_priv;
struct i2c_client *client = dev->client;
int ret;
- u32 tmp;
+ u32 uninitialized_var(tmp);
dev_dbg(&client->dev, "\n");
--
2.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rtl2832: remove compiler warning
2015-02-11 11:08 [PATCH v2] rtl2832: remove compiler warning Luis de Bethencourt
@ 2015-02-11 13:07 ` Antti Palosaari
2015-02-15 22:46 ` Luis de Bethencourt
1 sibling, 0 replies; 3+ messages in thread
From: Antti Palosaari @ 2015-02-11 13:07 UTC (permalink / raw)
To: Luis de Bethencourt, linux-media; +Cc: mchehab, crop, linux-kernel
On 02/11/2015 01:08 PM, Luis de Bethencourt wrote:
> Cleaning up the following compiler warning:
> rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
>
> Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> tmp, this line would never run because we go to err. It is still nice to avoid
> compiler warnings.
>
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Antti
> ---
> drivers/media/dvb-frontends/rtl2832.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> index 5d2d8f4..20fa245 100644
> --- a/drivers/media/dvb-frontends/rtl2832.c
> +++ b/drivers/media/dvb-frontends/rtl2832.c
> @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> struct rtl2832_dev *dev = fe->demodulator_priv;
> struct i2c_client *client = dev->client;
> int ret;
> - u32 tmp;
> + u32 uninitialized_var(tmp);
>
> dev_dbg(&client->dev, "\n");
>
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rtl2832: remove compiler warning
2015-02-11 11:08 [PATCH v2] rtl2832: remove compiler warning Luis de Bethencourt
2015-02-11 13:07 ` Antti Palosaari
@ 2015-02-15 22:46 ` Luis de Bethencourt
1 sibling, 0 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2015-02-15 22:46 UTC (permalink / raw)
To: mchehab; +Cc: crop, linux-kernel, linux-media
On Wed, Feb 11, 2015 at 11:08:51AM +0000, Luis de Bethencourt wrote:
> Cleaning up the following compiler warning:
> rtl2832.c:703:12: warning: 'tmp' may be used uninitialized in this function
>
> Even though it could never happen since if rtl2832_rd_demod_reg () doesn't set
> tmp, this line would never run because we go to err. It is still nice to avoid
> compiler warnings.
>
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> ---
> drivers/media/dvb-frontends/rtl2832.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c
> index 5d2d8f4..20fa245 100644
> --- a/drivers/media/dvb-frontends/rtl2832.c
> +++ b/drivers/media/dvb-frontends/rtl2832.c
> @@ -685,7 +685,7 @@ static int rtl2832_read_status(struct dvb_frontend *fe, fe_status_t *status)
> struct rtl2832_dev *dev = fe->demodulator_priv;
> struct i2c_client *client = dev->client;
> int ret;
> - u32 tmp;
> + u32 uninitialized_var(tmp);
>
> dev_dbg(&client->dev, "\n");
>
> --
> 2.1.3
>
Hi Mauro,
The warning is still happening. Just a reminder in case you want to apply this
patch.
Thanks,
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-15 22:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-11 11:08 [PATCH v2] rtl2832: remove compiler warning Luis de Bethencourt
2015-02-11 13:07 ` Antti Palosaari
2015-02-15 22:46 ` Luis de Bethencourt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).