linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: bhelgaas@google.com, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, x86@kernel.org, --cclinux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] x86:pci: Change  sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c
Date: Mon, 16 Feb 2015 08:55:06 +0100	[thread overview]
Message-ID: <20150216075506.GA25780@gmail.com> (raw)
In-Reply-To: <1424030062-8668-1-git-send-email-xerofoify@gmail.com>


* Nicholas Krause <xerofoify@gmail.com> wrote:

> This changes the structure sta2x11_dma_ops stucture to 
> use switolb_dma_supported as it's function for 
> dma_supported hardware verus setting this value to NULL 
> as this should be set correctly for when dma_supported 
> function needs to be called for this hardware. Otherwise 
> this will cause a bug that will crash a operation needing 
> to access this function if an intended hardware operation 
> needs to call it but the kernel has the function pointer 
> for this structure set to NULL incorrectly.

This is a pretty vague description - what specific hardware 
is affected and how is the bug triggered?

Thanks,

	Ingo

       reply	other threads:[~2015-02-16  7:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1424030062-8668-1-git-send-email-xerofoify@gmail.com>
2015-02-16  7:55 ` Ingo Molnar [this message]
     [not found]   ` <54E243F4.4040708@gmail.com>
2015-02-18 18:06     ` [PATCH RESEND] x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c Ingo Molnar
2015-02-16 21:39 ` Bjorn Helgaas
     [not found] <1425959625-14551-1-git-send-email-xerofoify@gmail.com>
2015-03-10  4:45 ` Ingo Molnar
     [not found]   ` <0393A100-7C14-4185-AD1A-5C2364B8CEE3@gmail.com>
2015-03-10  5:32     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150216075506.GA25780@gmail.com \
    --to=mingo@kernel.org \
    --cc=--cclinux-pci@vger.kernel.org \
    --cc=bhelgaas@google.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).