linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Mikko Perttunen <mikko.perttunen@kapsi.fi>
Cc: <swarren@wwwdotorg.org>, <thierry.reding@gmail.com>,
	<gnurou@gmail.com>, <rjw@rjwysocki.net>,
	<viresh.kumar@linaro.org>, <mturquette@linaro.org>,
	<pwalmsley@nvidia.com>, <vinceh@nvidia.com>,
	<pgaikwad@nvidia.com>, <linux-kernel@vger.kernel.org>,
	<linux-pm@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <tuomas.tynkkynen@iki.fi>,
	Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Subject: Re: [PATCH v7 05/16] clk: tegra: Add DFLL DVCO reset control for Tegra124
Date: Mon, 16 Feb 2015 11:40:01 +0200	[thread overview]
Message-ID: <20150216094000.GD19839@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <54DDD447.8000404@kapsi.fi>

On Fri, Feb 13, 2015 at 12:39:03PM +0200, Mikko Perttunen wrote:
> On 02/12/2015 04:19 PM, Peter De Schrijver wrote:
> >On Thu, Jan 08, 2015 at 03:22:08PM +0200, Mikko Perttunen wrote:
> >>From: Paul Walmsley <pwalmsley@nvidia.com>
> >>
> >>The DVCO present in the DFLL IP block has a separate reset line,
> >>exposed via the CAR IP block.  This reset line is asserted upon SoC
> >>reset.  Unless something (such as the DFLL driver) deasserts this
> >>line, the DVCO will not oscillate, although reads and writes to the
> >>DFLL IP block will complete.
> >>
> >>Thanks to Aleksandr Frid <afrid@nvidia.com> for identifying this and
> >>saving hours of debugging time.
> >>
> >
> >Should this be done as a reset driver?
> 
> Probably through the already existing CAR reset driver. This reset
> doesn't fit well with the existing numbering scheme there, though.
> Perhaps a magic high-valued constant that represents it.
> 

Indeed. Just like only the lower part of the clock IDs map have a realtion
with the hardware registers. The rest is just arbitrary numbers.

Cheers,

Peter.

  reply	other threads:[~2015-02-16  9:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 13:22 [PATCH v7 00/16] Tegra124 CL-DVFS / DFLL clocksource + cpufreq Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 01/16] clk: tegra: Add binding for the Tegra124 DFLL clocksource Mikko Perttunen
2015-02-12 13:54   ` Peter De Schrijver
2015-02-13 10:19     ` Mikko Perttunen
2015-02-12 22:42   ` Thierry Reding
2015-02-13  9:38     ` Peter De Schrijver
2015-02-13 10:18     ` Mikko Perttunen
2015-02-16  7:11     ` Tuomas Tynkkynen
2015-01-08 13:22 ` [PATCH v7 02/16] clk: tegra: Add library for the DFLL clock source (open-loop mode) Mikko Perttunen
2015-02-12 14:04   ` Peter De Schrijver
2015-01-08 13:22 ` [PATCH v7 03/16] clk: tegra: Add closed loop support for the DFLL Mikko Perttunen
2015-02-12 14:12   ` Peter De Schrijver
2015-01-08 13:22 ` [PATCH v7 04/16] clk: tegra: Add functions for parsing CVB tables Mikko Perttunen
2015-02-12 14:13   ` Peter De Schrijver
2015-01-08 13:22 ` [PATCH v7 05/16] clk: tegra: Add DFLL DVCO reset control for Tegra124 Mikko Perttunen
2015-02-12 14:19   ` Peter De Schrijver
2015-02-13 10:39     ` Mikko Perttunen
2015-02-16  9:40       ` Peter De Schrijver [this message]
2015-01-08 13:22 ` [PATCH v7 06/16] clk: tegra: Add Tegra124 DFLL clocksource platform driver Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 07/16] clk: tegra: Save/restore CCLKG_BURST_POLICY on suspend Mikko Perttunen
2015-02-12 14:24   ` Peter De Schrijver
2015-01-08 13:22 ` [PATCH v7 08/16] clk: tegra: Add the DFLL as a possible parent of the cclk_g clock Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 09/16] ARM: tegra: Add the DFLL to Tegra124 device tree Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 10/16] ARM: tegra: Enable the DFLL on the Jetson TK1 Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 11/16] cpufreq: tegra124: Add device tree bindings Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 12/16] cpufreq: tegra: Rename tegra-cpufreq to tegra20-cpufreq Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 13/16] cpufreq: Add cpufreq driver for Tegra124 Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 14/16] ARM: tegra: Add entries for cpufreq on Tegra124 Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 15/16] ARM: tegra: Add CPU regulator to the Jetson TK1 device tree Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 16/16] ARM: tegra: enable Tegra124 cpufreq driver by default Mikko Perttunen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150216094000.GD19839@tbergstrom-lnx.Nvidia.com \
    --to=pdeschrijver@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mikko.perttunen@kapsi.fi \
    --cc=mturquette@linaro.org \
    --cc=pgaikwad@nvidia.com \
    --cc=pwalmsley@nvidia.com \
    --cc=rjw@rjwysocki.net \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    --cc=ttynkkynen@nvidia.com \
    --cc=tuomas.tynkkynen@iki.fi \
    --cc=vinceh@nvidia.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).