linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Mikko Perttunen <mikko.perttunen@kapsi.fi>
Cc: <swarren@wwwdotorg.org>, <thierry.reding@gmail.com>,
	<gnurou@gmail.com>, <rjw@rjwysocki.net>,
	<viresh.kumar@linaro.org>, <mturquette@linaro.org>,
	<pwalmsley@nvidia.com>, <vinceh@nvidia.com>,
	<pgaikwad@nvidia.com>, <linux-kernel@vger.kernel.org>,
	<linux-pm@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <tuomas.tynkkynen@iki.fi>,
	Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Subject: Re: [PATCH v7 07/16] clk: tegra: Save/restore CCLKG_BURST_POLICY on suspend
Date: Thu, 12 Feb 2015 16:24:40 +0200	[thread overview]
Message-ID: <20150212142440.GL20811@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <1420723339-30735-8-git-send-email-mikko.perttunen@kapsi.fi>

On Thu, Jan 08, 2015 at 03:22:10PM +0200, Mikko Perttunen wrote:
> From: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
> 
> Save and restore this register since the LP1 restore assembly routines
> fiddle with it. Otherwise the CPU would keep running on PLLX after
> resume from suspend even when DFLL was the original clocksource.
> 
> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
> Signed-off-by: Mikko Perttunen <mikko.perttunen@kapsi.fi>
Acked-By: Peter De Schrijver <pdeschrijver@nvidia.com>

> ---
>  drivers/clk/tegra/clk-tegra124.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
> index 623b77f..9354c42 100644
> --- a/drivers/clk/tegra/clk-tegra124.c
> +++ b/drivers/clk/tegra/clk-tegra124.c
> @@ -89,6 +89,8 @@
>  #define PMC_PLLM_WB0_OVERRIDE 0x1dc
>  #define PMC_PLLM_WB0_OVERRIDE_2 0x2b0
>  
> +#define CCLKG_BURST_POLICY 0x368
> +
>  #define UTMIP_PLL_CFG2 0x488
>  #define UTMIP_PLL_CFG2_STABLE_COUNT(x) (((x) & 0xffff) << 6)
>  #define UTMIP_PLL_CFG2_ACTIVE_DLY_COUNT(x) (((x) & 0x3f) << 18)
> @@ -121,6 +123,8 @@
>  #ifdef CONFIG_PM_SLEEP
>  static struct cpu_clk_suspend_context {
>  	u32 clk_csite_src;
> +	u32 cclkg_burst;
> +	u32 cclkg_divider;
>  } tegra124_cpu_clk_sctx;
>  #endif
>  
> @@ -1331,12 +1335,22 @@ static void tegra124_cpu_clock_suspend(void)
>  	tegra124_cpu_clk_sctx.clk_csite_src =
>  				readl(clk_base + CLK_SOURCE_CSITE);
>  	writel(3 << 30, clk_base + CLK_SOURCE_CSITE);
> +
> +	tegra124_cpu_clk_sctx.cclkg_burst =
> +				readl(clk_base + CCLKG_BURST_POLICY);
> +	tegra124_cpu_clk_sctx.cclkg_divider =
> +				readl(clk_base + CCLKG_BURST_POLICY + 4);
>  }
>  
>  static void tegra124_cpu_clock_resume(void)
>  {
>  	writel(tegra124_cpu_clk_sctx.clk_csite_src,
>  				clk_base + CLK_SOURCE_CSITE);
> +
> +	writel(tegra124_cpu_clk_sctx.cclkg_burst,
> +					clk_base + CCLKG_BURST_POLICY);
> +	writel(tegra124_cpu_clk_sctx.cclkg_divider,
> +					clk_base + CCLKG_BURST_POLICY + 4);
>  }
>  #endif
>  
> -- 
> 2.2.1
> 

  reply	other threads:[~2015-02-12 14:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 13:22 [PATCH v7 00/16] Tegra124 CL-DVFS / DFLL clocksource + cpufreq Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 01/16] clk: tegra: Add binding for the Tegra124 DFLL clocksource Mikko Perttunen
2015-02-12 13:54   ` Peter De Schrijver
2015-02-13 10:19     ` Mikko Perttunen
2015-02-12 22:42   ` Thierry Reding
2015-02-13  9:38     ` Peter De Schrijver
2015-02-13 10:18     ` Mikko Perttunen
2015-02-16  7:11     ` Tuomas Tynkkynen
2015-01-08 13:22 ` [PATCH v7 02/16] clk: tegra: Add library for the DFLL clock source (open-loop mode) Mikko Perttunen
2015-02-12 14:04   ` Peter De Schrijver
2015-01-08 13:22 ` [PATCH v7 03/16] clk: tegra: Add closed loop support for the DFLL Mikko Perttunen
2015-02-12 14:12   ` Peter De Schrijver
2015-01-08 13:22 ` [PATCH v7 04/16] clk: tegra: Add functions for parsing CVB tables Mikko Perttunen
2015-02-12 14:13   ` Peter De Schrijver
2015-01-08 13:22 ` [PATCH v7 05/16] clk: tegra: Add DFLL DVCO reset control for Tegra124 Mikko Perttunen
2015-02-12 14:19   ` Peter De Schrijver
2015-02-13 10:39     ` Mikko Perttunen
2015-02-16  9:40       ` Peter De Schrijver
2015-01-08 13:22 ` [PATCH v7 06/16] clk: tegra: Add Tegra124 DFLL clocksource platform driver Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 07/16] clk: tegra: Save/restore CCLKG_BURST_POLICY on suspend Mikko Perttunen
2015-02-12 14:24   ` Peter De Schrijver [this message]
2015-01-08 13:22 ` [PATCH v7 08/16] clk: tegra: Add the DFLL as a possible parent of the cclk_g clock Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 09/16] ARM: tegra: Add the DFLL to Tegra124 device tree Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 10/16] ARM: tegra: Enable the DFLL on the Jetson TK1 Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 11/16] cpufreq: tegra124: Add device tree bindings Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 12/16] cpufreq: tegra: Rename tegra-cpufreq to tegra20-cpufreq Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 13/16] cpufreq: Add cpufreq driver for Tegra124 Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 14/16] ARM: tegra: Add entries for cpufreq on Tegra124 Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 15/16] ARM: tegra: Add CPU regulator to the Jetson TK1 device tree Mikko Perttunen
2015-01-08 13:22 ` [PATCH v7 16/16] ARM: tegra: enable Tegra124 cpufreq driver by default Mikko Perttunen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150212142440.GL20811@tbergstrom-lnx.Nvidia.com \
    --to=pdeschrijver@nvidia.com \
    --cc=gnurou@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mikko.perttunen@kapsi.fi \
    --cc=mturquette@linaro.org \
    --cc=pgaikwad@nvidia.com \
    --cc=pwalmsley@nvidia.com \
    --cc=rjw@rjwysocki.net \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    --cc=ttynkkynen@nvidia.com \
    --cc=tuomas.tynkkynen@iki.fi \
    --cc=vinceh@nvidia.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).