From: Lee Jones <lee.jones@linaro.org>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
lejun.zhu@linux.intel.com, bin.yang@intel.com
Subject: Re: [PATCH 3/3] mfd: intel_soc_pmic: Ensure GPIO irq is set to input pin
Date: Mon, 16 Feb 2015 11:49:59 +0000 [thread overview]
Message-ID: <20150216114959.GD2037@x1> (raw)
In-Reply-To: <1423832475-5803-3-git-send-email-jarkko.nikula@linux.intel.com>
On Fri, 13 Feb 2015, Jarkko Nikula wrote:
> Surely GPIO irq will be used as an input pin so make sure its direction is
> set after requesting.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> Again, I haven't seen any issue. Just a thought if BIOS haven't configured
> the pin correctly.
> ---
> drivers/mfd/intel_soc_pmic_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index 40488e5b52ef..857e5cccdb49 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -31,7 +31,7 @@ static int intel_soc_pmic_find_gpio_irq(struct device *dev)
> struct gpio_desc *desc;
> int irq;
>
> - desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0);
> + desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0, GPIOD_IN);
> if (IS_ERR(desc))
> return PTR_ERR(desc);
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-02-16 11:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 13:01 [PATCH 1/3] mfd: intel_soc_pmic: Move PMIC interrupt comment to probe function Jarkko Nikula
2015-02-13 13:01 ` [PATCH 2/3] mfd: intel_soc_pmic: Do not mangle error code from devm_gpiod_get_index() Jarkko Nikula
2015-02-16 11:49 ` Lee Jones
2015-02-13 13:01 ` [PATCH 3/3] mfd: intel_soc_pmic: Ensure GPIO irq is set to input pin Jarkko Nikula
2015-02-16 11:49 ` Lee Jones [this message]
2015-02-16 11:49 ` [PATCH 1/3] mfd: intel_soc_pmic: Move PMIC interrupt comment to probe function Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216114959.GD2037@x1 \
--to=lee.jones@linaro.org \
--cc=bin.yang@intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lejun.zhu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).