* [PATCH block] NVMe: nvme_meta_noop can be static
2015-02-21 7:17 [block:for-linus 1/10] drivers/block/nvme-core.c:2008:22: sparse: symbol 'nvme_meta_noop' was not declared. Should it be static? kbuild test robot
@ 2015-02-21 7:17 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-02-21 7:17 UTC (permalink / raw)
To: Keith Busch; +Cc: kbuild-all, Matthew Wilcox, linux-nvme, linux-kernel
drivers/block/nvme-core.c:2008:22: sparse: symbol 'nvme_meta_noop' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
nvme-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index 3ffa57a..384c786 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme-core.c
@@ -2005,7 +2005,7 @@ static int nvme_noop_generate(struct blk_integrity_iter *iter)
return 0;
}
-struct blk_integrity nvme_meta_noop = {
+static struct blk_integrity nvme_meta_noop = {
.name = "NVME_META_NOOP",
.generate_fn = nvme_noop_generate,
.verify_fn = nvme_noop_verify,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [block:for-linus 1/10] drivers/block/nvme-core.c:2008:22: sparse: symbol 'nvme_meta_noop' was not declared. Should it be static?
@ 2015-02-21 7:17 kbuild test robot
2015-02-21 7:17 ` [PATCH block] NVMe: nvme_meta_noop can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-02-21 7:17 UTC (permalink / raw)
To: Keith Busch; +Cc: kbuild-all, Matthew Wilcox, linux-nvme, linux-kernel
tree: git://git.kernel.dk/linux-block.git for-linus
head: decf6d79de84e427d409ff74156af2e77ffadd84
commit: e1e5e5641e6f271321aec257ed26a72715e4a8c2 [1/10] NVMe: Metadata format support
reproduce:
# apt-get install sparse
git checkout e1e5e5641e6f271321aec257ed26a72715e4a8c2
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/block/nvme-core.c:2008:22: sparse: symbol 'nvme_meta_noop' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-21 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-21 7:17 [block:for-linus 1/10] drivers/block/nvme-core.c:2008:22: sparse: symbol 'nvme_meta_noop' was not declared. Should it be static? kbuild test robot
2015-02-21 7:17 ` [PATCH block] NVMe: nvme_meta_noop can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).