From: Lee Jones <lee.jones@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, maxime.coquelin@st.com,
patrice.chotard@st.com, srinivas.kandagatla@gmail.com,
tj@kernel.org, linux-ide@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] ahci: st: Update the ahci_st DT documentation
Date: Mon, 2 Mar 2015 16:59:47 +0000 [thread overview]
Message-ID: <20150302165947.GA6976@x1> (raw)
In-Reply-To: <1425300519-13747-2-git-send-email-peter.griffin@linaro.org>
On Mon, 02 Mar 2015, Peter Griffin wrote:
> As part of testing ahci_st driver working on stih407 I noticed
> several things wrong in the DT documentation: -
>
> 1) Compatible string doesn't match the driver code
> 2) pwr-rst reset isn't documented (but exists in the driver)
> 3) some whitespace issues (spaces not tabs)
>
> Also add in a stih407 family example into the doc.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> Documentation/devicetree/bindings/ata/ahci-st.txt | 45 ++++++++++++++++-------
> 1 file changed, 32 insertions(+), 13 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-st.txt b/Documentation/devicetree/bindings/ata/ahci-st.txt
> index 1331202..e1d01df 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-st.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-st.txt
> @@ -3,29 +3,48 @@ STMicroelectronics STi SATA controller
> This binding describes a SATA device.
>
> Required properties:
> - - compatible : Must be "st,sti-ahci"
> + - compatible : Must be "st,ahci"
> - reg : Physical base addresses and length of register sets
> - interrupts : Interrupt associated with the SATA device
> - interrupt-names : Associated name must be; "hostc"
> - - resets : The power-down and soft-reset lines of SATA IP
> - - reset-names : Associated names must be; "pwr-dwn" and "sw-rst"
> - clocks : The phandle for the clock
> - clock-names : Associated name must be; "ahci_clk"
> - phys : The phandle for the PHY port
> - phy-names : Associated name must be; "ahci_phy"
>
> +Optional properties:
> + - resets : The power-down, soft-reset and power-reset lines of SATA IP
> + - reset-names : Associated names must be; "pwr-dwn", "sw-rst" and "pwr-rst"
> +
> Example:
>
> + /* Example for stih416 */
> sata0: sata@fe380000 {
> - compatible = "st,sti-ahci";
> - reg = <0xfe380000 0x1000>;
> - interrupts = <GIC_SPI 157 IRQ_TYPE_NONE>;
> - interrupt-names = "hostc";
> - phys = <&phy_port0 PHY_TYPE_SATA>;
> - phy-names = "ahci_phy";
> - resets = <&powerdown STIH416_SATA0_POWERDOWN>,
> + compatible = "st,ahci";
> + reg = <0xfe380000 0x1000>;
> + interrupts = <GIC_SPI 157 IRQ_TYPE_NONE>;
> + interrupt-names = "hostc";
> + phys = <&phy_port0 PHY_TYPE_SATA>;
> + phy-names = "ahci_phy";
> + resets = <&powerdown STIH416_SATA0_POWERDOWN>,
> <&softreset STIH416_SATA0_SOFTRESET>;
> - reset-names = "pwr-dwn", "sw-rst";
> - clocks = <&clk_s_a0_ls CLK_ICN_REG>;
> - clock-names = "ahci_clk";
> + reset-names = "pwr-dwn", "sw-rst";
> + clocks = <&clk_s_a0_ls CLK_ICN_REG>;
> + clock-names = "ahci_clk";
> + };
> +
> + /* Example for stih407 family silicon */
> + sata0: sata@9b20000 {
> + compatible = "st,ahci";
> + reg = <0x9b20000 0x1000>;
> + interrupts = <GIC_SPI 159 IRQ_TYPE_NONE>;
> + interrupt-names = "hostc";
> + phys = <&phy_port0 PHY_TYPE_SATA>;
> + phy-names = "ahci_phy";
> + resets = <&powerdown STIH407_SATA0_POWERDOWN>,
> + <&softreset STIH407_SATA0_SOFTRESET>,
> + <&softreset STIH407_SATA0_PWR_SOFTRESET>;
> + reset-names = "pwr-dwn", "sw-rst", "pwr-rst";
> + clocks = <&clk_s_c0_flexgen CLK_ICN_REG>;
> + clock-names = "ahci_clk";
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-03-02 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 12:48 [PATCH 0/3] Enable ahci_st for stih407 and fix hang Peter Griffin
2015-03-02 12:48 ` [PATCH 1/3] ahci: st: Update the ahci_st DT documentation Peter Griffin
2015-03-02 16:59 ` Lee Jones [this message]
2015-03-02 12:48 ` [PATCH 2/3] ARM: DT: STi: STiH407: Add sata DT nodes Peter Griffin
2015-03-02 17:00 ` Lee Jones
2015-03-02 12:48 ` [PATCH 3/3] ahci: st: st_configure_oob must be called after IP is clocked Peter Griffin
2015-03-02 17:03 ` Lee Jones
2015-03-03 12:23 ` [PATCH 0/3] Enable ahci_st for stih407 and fix hang Maxime Coquelin
2015-03-31 7:35 [PATCH RESEND " Peter Griffin
2015-03-31 7:35 ` [PATCH 1/3] ahci: st: Update the ahci_st DT documentation Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302165947.GA6976@x1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=patrice.chotard@st.com \
--cc=peter.griffin@linaro.org \
--cc=srinivas.kandagatla@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).