* [PATCH] arch: mips: kvm: Enable after disabling interrupt
@ 2015-02-22 16:18 Tapasweni Pathak
2015-02-23 14:07 ` James Hogan
2015-03-02 22:18 ` Marcelo Tosatti
0 siblings, 2 replies; 3+ messages in thread
From: Tapasweni Pathak @ 2015-02-22 16:18 UTC (permalink / raw)
To: gleb, pbonzini, ralf, kvm, linux-mips, linux-kernel
Cc: julia.lawall, tapaswenipathak
Enable disabled interrupt, on unsuccessful operation.
Found by Coccinelle.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
arch/mips/kvm/tlb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/kvm/tlb.c b/arch/mips/kvm/tlb.c
index bbcd822..b6beb0e 100644
--- a/arch/mips/kvm/tlb.c
+++ b/arch/mips/kvm/tlb.c
@@ -216,6 +216,7 @@ int kvm_mips_host_tlb_write(struct kvm_vcpu *vcpu, unsigned long entryhi,
if (idx > current_cpu_data.tlbsize) {
kvm_err("%s: Invalid Index: %d\n", __func__, idx);
kvm_mips_dump_host_tlbs();
+ local_irq_restore(flags);
return -1;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arch: mips: kvm: Enable after disabling interrupt
2015-02-22 16:18 [PATCH] arch: mips: kvm: Enable after disabling interrupt Tapasweni Pathak
@ 2015-02-23 14:07 ` James Hogan
2015-03-02 22:18 ` Marcelo Tosatti
1 sibling, 0 replies; 3+ messages in thread
From: James Hogan @ 2015-02-23 14:07 UTC (permalink / raw)
To: Tapasweni Pathak
Cc: gleb, pbonzini, ralf, kvm, linux-mips, linux-kernel, julia.lawall
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
On Sun, Feb 22, 2015 at 09:48:21PM +0530, Tapasweni Pathak wrote:
> Enable disabled interrupt, on unsuccessful operation.
>
> Found by Coccinelle.
>
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
> ---
> arch/mips/kvm/tlb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/kvm/tlb.c b/arch/mips/kvm/tlb.c
> index bbcd822..b6beb0e 100644
> --- a/arch/mips/kvm/tlb.c
> +++ b/arch/mips/kvm/tlb.c
> @@ -216,6 +216,7 @@ int kvm_mips_host_tlb_write(struct kvm_vcpu *vcpu, unsigned long entryhi,
> if (idx > current_cpu_data.tlbsize) {
> kvm_err("%s: Invalid Index: %d\n", __func__, idx);
> kvm_mips_dump_host_tlbs();
> + local_irq_restore(flags);
> return -1;
> }
>
> --
> 1.7.9.5
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arch: mips: kvm: Enable after disabling interrupt
2015-02-22 16:18 [PATCH] arch: mips: kvm: Enable after disabling interrupt Tapasweni Pathak
2015-02-23 14:07 ` James Hogan
@ 2015-03-02 22:18 ` Marcelo Tosatti
1 sibling, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2015-03-02 22:18 UTC (permalink / raw)
To: Tapasweni Pathak
Cc: gleb, pbonzini, ralf, kvm, linux-mips, linux-kernel, julia.lawall
On Sun, Feb 22, 2015 at 09:48:21PM +0530, Tapasweni Pathak wrote:
> Enable disabled interrupt, on unsuccessful operation.
>
> Found by Coccinelle.
>
> Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> arch/mips/kvm/tlb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/kvm/tlb.c b/arch/mips/kvm/tlb.c
> index bbcd822..b6beb0e 100644
> --- a/arch/mips/kvm/tlb.c
> +++ b/arch/mips/kvm/tlb.c
> @@ -216,6 +216,7 @@ int kvm_mips_host_tlb_write(struct kvm_vcpu *vcpu, unsigned long entryhi,
> if (idx > current_cpu_data.tlbsize) {
> kvm_err("%s: Invalid Index: %d\n", __func__, idx);
> kvm_mips_dump_host_tlbs();
> + local_irq_restore(flags);
> return -1;
> }
>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-02 22:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-22 16:18 [PATCH] arch: mips: kvm: Enable after disabling interrupt Tapasweni Pathak
2015-02-23 14:07 ` James Hogan
2015-03-02 22:18 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).