linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: Fix ipq806x LCC frequency tables
@ 2015-02-27  3:37 Stephen Boyd
  2015-03-03  0:10 ` Kenneth Westfield
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2015-02-27  3:37 UTC (permalink / raw)
  To: Mike Turquette, Stephen Boyd
  Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, Kenneth Westfield

These frequency tables list the wrong rates. Either they don't
have the correct frequency at all, or they're specified in kHz
instead of Hz. Fix it.

Fixes: c99e515a92e9 "clk: qcom: Add IPQ806X LPASS clock controller (LCC) driver"
Cc: Kenneth Westfield <kwestfie@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/clk/qcom/lcc-ipq806x.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/clk/qcom/lcc-ipq806x.c b/drivers/clk/qcom/lcc-ipq806x.c
index fb276522173a..b23f8069fac1 100644
--- a/drivers/clk/qcom/lcc-ipq806x.c
+++ b/drivers/clk/qcom/lcc-ipq806x.c
@@ -294,14 +294,14 @@ static struct clk_regmap_mux pcm_clk = {
 };
 
 static struct freq_tbl clk_tbl_aif_osr[] = {
-	{  22050, P_PLL4, 1, 147, 20480 },
-	{  32000, P_PLL4, 1,   1,    96 },
-	{  44100, P_PLL4, 1, 147, 10240 },
-	{  48000, P_PLL4, 1,   1,    64 },
-	{  88200, P_PLL4, 1, 147,  5120 },
-	{  96000, P_PLL4, 1,   1,    32 },
-	{ 176400, P_PLL4, 1, 147,  2560 },
-	{ 192000, P_PLL4, 1,   1,    16 },
+	{  2822400, P_PLL4, 1, 147, 20480 },
+	{  4096000, P_PLL4, 1,   1,    96 },
+	{  5644800, P_PLL4, 1, 147, 10240 },
+	{  6144000, P_PLL4, 1,   1,    64 },
+	{ 11289600, P_PLL4, 1, 147,  5120 },
+	{ 12288000, P_PLL4, 1,   1,    32 },
+	{ 22579200, P_PLL4, 1, 147,  2560 },
+	{ 24576000, P_PLL4, 1,   1,    16 },
 	{ },
 };
 
@@ -360,7 +360,7 @@ static struct clk_branch spdif_clk = {
 };
 
 static struct freq_tbl clk_tbl_ahbix[] = {
-	{ 131072, P_PLL4, 1, 1, 3 },
+	{ 131072000, P_PLL4, 1, 1, 3 },
 	{ },
 };
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: Fix ipq806x LCC frequency tables
  2015-02-27  3:37 [PATCH] clk: qcom: Fix ipq806x LCC frequency tables Stephen Boyd
@ 2015-03-03  0:10 ` Kenneth Westfield
  2015-03-27  5:46   ` Stephen Boyd
  0 siblings, 1 reply; 3+ messages in thread
From: Kenneth Westfield @ 2015-03-03  0:10 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Mike Turquette, linux-kernel, linux-arm-msm, linux-arm-kernel,
	Kenneth Westfield

On Thu, Feb 26, 2015 at 07:37:44PM -0800, Stephen Boyd wrote:
> These frequency tables list the wrong rates. Either they don't
> have the correct frequency at all, or they're specified in kHz
> instead of Hz. Fix it.
> 
> Fixes: c99e515a92e9 "clk: qcom: Add IPQ806X LPASS clock controller (LCC) driver"
> Cc: Kenneth Westfield <kwestfie@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>  drivers/clk/qcom/lcc-ipq806x.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

Verified audio functionality on the Storm board (w/o SPDIF).

Tested-by: Kenneth Westfield <kwestfie@codeaurora.org>

-- 
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: qcom: Fix ipq806x LCC frequency tables
  2015-03-03  0:10 ` Kenneth Westfield
@ 2015-03-27  5:46   ` Stephen Boyd
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2015-03-27  5:46 UTC (permalink / raw)
  To: Kenneth Westfield, Mike Turquette, linux-kernel, linux-arm-msm,
	linux-arm-kernel

On 03/02, Kenneth Westfield wrote:
> On Thu, Feb 26, 2015 at 07:37:44PM -0800, Stephen Boyd wrote:
> > These frequency tables list the wrong rates. Either they don't
> > have the correct frequency at all, or they're specified in kHz
> > instead of Hz. Fix it.
> > 
> > Fixes: c99e515a92e9 "clk: qcom: Add IPQ806X LPASS clock controller (LCC) driver"
> > Cc: Kenneth Westfield <kwestfie@codeaurora.org>
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> >  drivers/clk/qcom/lcc-ipq806x.c | 18 +++++++++---------
> >  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> Verified audio functionality on the Storm board (w/o SPDIF).
> 
> Tested-by: Kenneth Westfield <kwestfie@codeaurora.org>
> 

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-27  5:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-27  3:37 [PATCH] clk: qcom: Fix ipq806x LCC frequency tables Stephen Boyd
2015-03-03  0:10 ` Kenneth Westfield
2015-03-27  5:46   ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).