* [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
@ 2015-02-27 14:06 Matt Porter
2015-03-03 3:41 ` Shawn Guo
2015-03-06 4:40 ` Shawn Guo
0 siblings, 2 replies; 6+ messages in thread
From: Matt Porter @ 2015-02-27 14:06 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer
Cc: Devicetree List, Linux ARM Kernel List, Linux Kernel Mailing List
The chipidea driver adds an extra line of spam to the log when a
host-only chipidea instance is left set to the default of a dual role
controller.
[ 2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget
Set the dr_mode property to host on all the host-only nodes
to avoid this warning.
Signed-off-by: Matt Porter <mporter@konsulko.com>
---
arch/arm/boot/dts/imx27.dtsi | 2 ++
arch/arm/boot/dts/imx28.dtsi | 1 +
arch/arm/boot/dts/imx35.dtsi | 1 +
arch/arm/boot/dts/imx50.dtsi | 3 +++
arch/arm/boot/dts/imx51.dtsi | 3 +++
arch/arm/boot/dts/imx53.dtsi | 3 +++
arch/arm/boot/dts/imx6qdl.dtsi | 3 +++
arch/arm/boot/dts/imx6sl.dtsi | 1 +
arch/arm/boot/dts/imx6sx.dtsi | 1 +
9 files changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
index 4b063b6..6951b66 100644
--- a/arch/arm/boot/dts/imx27.dtsi
+++ b/arch/arm/boot/dts/imx27.dtsi
@@ -488,6 +488,7 @@
interrupts = <54>;
clocks = <&clks IMX27_CLK_USB_IPG_GATE>;
fsl,usbmisc = <&usbmisc 1>;
+ dr_mode = "host";
status = "disabled";
};
@@ -497,6 +498,7 @@
interrupts = <55>;
clocks = <&clks IMX27_CLK_USB_IPG_GATE>;
fsl,usbmisc = <&usbmisc 2>;
+ dr_mode = "host";
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 47f68ac..02330f4 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -1197,6 +1197,7 @@
interrupts = <92>;
clocks = <&clks 61>;
fsl,usbphy = <&usbphy1>;
+ dr_mode = "host";
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
index 6932928..b6478e9 100644
--- a/arch/arm/boot/dts/imx35.dtsi
+++ b/arch/arm/boot/dts/imx35.dtsi
@@ -318,6 +318,7 @@
clocks = <&clks 73>;
fsl,usbmisc = <&usbmisc 1>;
fsl,usbphy = <&usbphy1>;
+ dr_mode = "host";
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
index 620b0f0..e245713 100644
--- a/arch/arm/boot/dts/imx50.dtsi
+++ b/arch/arm/boot/dts/imx50.dtsi
@@ -197,6 +197,7 @@
reg = <0x53f80200 0x0200>;
interrupts = <14>;
clocks = <&clks IMX5_CLK_USB_PHY2_GATE>;
+ dr_mode = "host";
status = "disabled";
};
@@ -205,6 +206,7 @@
reg = <0x53f80400 0x0200>;
interrupts = <16>;
clocks = <&clks IMX5_CLK_USBOH3_GATE>;
+ dr_mode = "host";
status = "disabled";
};
@@ -213,6 +215,7 @@
reg = <0x53f80600 0x0200>;
interrupts = <17>;
clocks = <&clks IMX5_CLK_USBOH3_GATE>;
+ dr_mode = "host";
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index c0116cf..f46fe9b 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++ b/arch/arm/boot/dts/imx51.dtsi
@@ -265,6 +265,7 @@
interrupts = <14>;
clocks = <&clks IMX5_CLK_USBOH3_GATE>;
fsl,usbmisc = <&usbmisc 1>;
+ dr_mode = "host";
status = "disabled";
};
@@ -274,6 +275,7 @@
interrupts = <16>;
clocks = <&clks IMX5_CLK_USBOH3_GATE>;
fsl,usbmisc = <&usbmisc 2>;
+ dr_mode = "host";
status = "disabled";
};
@@ -283,6 +285,7 @@
interrupts = <17>;
clocks = <&clks IMX5_CLK_USBOH3_GATE>;
fsl,usbmisc = <&usbmisc 3>;
+ dr_mode = "host";
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index ff4fa7e..c3e3ca9 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -309,6 +309,7 @@
clocks = <&clks IMX5_CLK_USBOH3_GATE>;
fsl,usbmisc = <&usbmisc 1>;
fsl,usbphy = <&usbphy1>;
+ dr_mode = "host";
status = "disabled";
};
@@ -318,6 +319,7 @@
interrupts = <16>;
clocks = <&clks IMX5_CLK_USBOH3_GATE>;
fsl,usbmisc = <&usbmisc 2>;
+ dr_mode = "host";
status = "disabled";
};
@@ -327,6 +329,7 @@
interrupts = <17>;
clocks = <&clks IMX5_CLK_USBOH3_GATE>;
fsl,usbmisc = <&usbmisc 3>;
+ dr_mode = "host";
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index d6c69ec..9347c93 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -845,6 +845,7 @@
clocks = <&clks IMX6QDL_CLK_USBOH3>;
fsl,usbphy = <&usbphy2>;
fsl,usbmisc = <&usbmisc 1>;
+ dr_mode = "host";
status = "disabled";
};
@@ -854,6 +855,7 @@
interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6QDL_CLK_USBOH3>;
fsl,usbmisc = <&usbmisc 2>;
+ dr_mode = "host";
status = "disabled";
};
@@ -863,6 +865,7 @@
interrupts = <0 42 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6QDL_CLK_USBOH3>;
fsl,usbmisc = <&usbmisc 3>;
+ dr_mode = "host";
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 36ab8e0..9bf1db3 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -699,6 +699,7 @@
interrupts = <0 40 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks IMX6SL_CLK_USBOH3>;
fsl,usbmisc = <&usbmisc 2>;
+ dr_mode = "host";
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 7a24fee..fdadd060 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -763,6 +763,7 @@
fsl,usbmisc = <&usbmisc 2>;
phy_type = "hsic";
fsl,anatop = <&anatop>;
+ dr_mode = "host";
status = "disabled";
};
--
1.8.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
2015-02-27 14:06 [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances Matt Porter
@ 2015-03-03 3:41 ` Shawn Guo
2015-03-03 4:43 ` Peter Chen
2015-03-06 4:40 ` Shawn Guo
1 sibling, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2015-03-03 3:41 UTC (permalink / raw)
To: Matt Porter, Peter Chen
Cc: Sascha Hauer, Devicetree List, Linux ARM Kernel List,
Linux Kernel Mailing List
Peter,
Can you take a look at Matt's patch below?
Shawn
On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote:
> The chipidea driver adds an extra line of spam to the log when a
> host-only chipidea instance is left set to the default of a dual role
> controller.
>
> [ 2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget
>
> Set the dr_mode property to host on all the host-only nodes
> to avoid this warning.
>
> Signed-off-by: Matt Porter <mporter@konsulko.com>
> ---
> arch/arm/boot/dts/imx27.dtsi | 2 ++
> arch/arm/boot/dts/imx28.dtsi | 1 +
> arch/arm/boot/dts/imx35.dtsi | 1 +
> arch/arm/boot/dts/imx50.dtsi | 3 +++
> arch/arm/boot/dts/imx51.dtsi | 3 +++
> arch/arm/boot/dts/imx53.dtsi | 3 +++
> arch/arm/boot/dts/imx6qdl.dtsi | 3 +++
> arch/arm/boot/dts/imx6sl.dtsi | 1 +
> arch/arm/boot/dts/imx6sx.dtsi | 1 +
> 9 files changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> index 4b063b6..6951b66 100644
> --- a/arch/arm/boot/dts/imx27.dtsi
> +++ b/arch/arm/boot/dts/imx27.dtsi
> @@ -488,6 +488,7 @@
> interrupts = <54>;
> clocks = <&clks IMX27_CLK_USB_IPG_GATE>;
> fsl,usbmisc = <&usbmisc 1>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> @@ -497,6 +498,7 @@
> interrupts = <55>;
> clocks = <&clks IMX27_CLK_USB_IPG_GATE>;
> fsl,usbmisc = <&usbmisc 2>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 47f68ac..02330f4 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -1197,6 +1197,7 @@
> interrupts = <92>;
> clocks = <&clks 61>;
> fsl,usbphy = <&usbphy1>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
> index 6932928..b6478e9 100644
> --- a/arch/arm/boot/dts/imx35.dtsi
> +++ b/arch/arm/boot/dts/imx35.dtsi
> @@ -318,6 +318,7 @@
> clocks = <&clks 73>;
> fsl,usbmisc = <&usbmisc 1>;
> fsl,usbphy = <&usbphy1>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
> index 620b0f0..e245713 100644
> --- a/arch/arm/boot/dts/imx50.dtsi
> +++ b/arch/arm/boot/dts/imx50.dtsi
> @@ -197,6 +197,7 @@
> reg = <0x53f80200 0x0200>;
> interrupts = <14>;
> clocks = <&clks IMX5_CLK_USB_PHY2_GATE>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> @@ -205,6 +206,7 @@
> reg = <0x53f80400 0x0200>;
> interrupts = <16>;
> clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> @@ -213,6 +215,7 @@
> reg = <0x53f80600 0x0200>;
> interrupts = <17>;
> clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
> index c0116cf..f46fe9b 100644
> --- a/arch/arm/boot/dts/imx51.dtsi
> +++ b/arch/arm/boot/dts/imx51.dtsi
> @@ -265,6 +265,7 @@
> interrupts = <14>;
> clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> fsl,usbmisc = <&usbmisc 1>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> @@ -274,6 +275,7 @@
> interrupts = <16>;
> clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> fsl,usbmisc = <&usbmisc 2>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> @@ -283,6 +285,7 @@
> interrupts = <17>;
> clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> fsl,usbmisc = <&usbmisc 3>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> index ff4fa7e..c3e3ca9 100644
> --- a/arch/arm/boot/dts/imx53.dtsi
> +++ b/arch/arm/boot/dts/imx53.dtsi
> @@ -309,6 +309,7 @@
> clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> fsl,usbmisc = <&usbmisc 1>;
> fsl,usbphy = <&usbphy1>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> @@ -318,6 +319,7 @@
> interrupts = <16>;
> clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> fsl,usbmisc = <&usbmisc 2>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> @@ -327,6 +329,7 @@
> interrupts = <17>;
> clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> fsl,usbmisc = <&usbmisc 3>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index d6c69ec..9347c93 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -845,6 +845,7 @@
> clocks = <&clks IMX6QDL_CLK_USBOH3>;
> fsl,usbphy = <&usbphy2>;
> fsl,usbmisc = <&usbmisc 1>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> @@ -854,6 +855,7 @@
> interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6QDL_CLK_USBOH3>;
> fsl,usbmisc = <&usbmisc 2>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> @@ -863,6 +865,7 @@
> interrupts = <0 42 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6QDL_CLK_USBOH3>;
> fsl,usbmisc = <&usbmisc 3>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 36ab8e0..9bf1db3 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -699,6 +699,7 @@
> interrupts = <0 40 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6SL_CLK_USBOH3>;
> fsl,usbmisc = <&usbmisc 2>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 7a24fee..fdadd060 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -763,6 +763,7 @@
> fsl,usbmisc = <&usbmisc 2>;
> phy_type = "hsic";
> fsl,anatop = <&anatop>;
> + dr_mode = "host";
> status = "disabled";
> };
>
> --
> 1.8.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
2015-03-03 3:41 ` Shawn Guo
@ 2015-03-03 4:43 ` Peter Chen
2015-03-03 15:08 ` Matt Porter
0 siblings, 1 reply; 6+ messages in thread
From: Peter Chen @ 2015-03-03 4:43 UTC (permalink / raw)
To: Shawn Guo
Cc: Matt Porter, Sascha Hauer, Devicetree List,
Linux ARM Kernel List, Linux Kernel Mailing List
On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote:
>
> On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote:
> > The chipidea driver adds an extra line of spam to the log when a
> > host-only chipidea instance is left set to the default of a dual role
> > controller.
> >
> > [ 2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget
> >
> > Set the dr_mode property to host on all the host-only nodes
> > to avoid this warning.
It is not an warning, it is dev_info.
In fact, imx28, imx6sl and imx6sx's second controller is dual-role
controller, we only set dr_mode at board's dts according to design
unless the controller's capability register is incorrect.
So, sorry, I don't think this change is necessary.
> >
> > Signed-off-by: Matt Porter <mporter@konsulko.com>
> > ---
> > arch/arm/boot/dts/imx27.dtsi | 2 ++
> > arch/arm/boot/dts/imx28.dtsi | 1 +
> > arch/arm/boot/dts/imx35.dtsi | 1 +
> > arch/arm/boot/dts/imx50.dtsi | 3 +++
> > arch/arm/boot/dts/imx51.dtsi | 3 +++
> > arch/arm/boot/dts/imx53.dtsi | 3 +++
> > arch/arm/boot/dts/imx6qdl.dtsi | 3 +++
> > arch/arm/boot/dts/imx6sl.dtsi | 1 +
> > arch/arm/boot/dts/imx6sx.dtsi | 1 +
> > 9 files changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index 4b063b6..6951b66 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
> > @@ -488,6 +488,7 @@
> > interrupts = <54>;
> > clocks = <&clks IMX27_CLK_USB_IPG_GATE>;
> > fsl,usbmisc = <&usbmisc 1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -497,6 +498,7 @@
> > interrupts = <55>;
> > clocks = <&clks IMX27_CLK_USB_IPG_GATE>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 47f68ac..02330f4 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -1197,6 +1197,7 @@
> > interrupts = <92>;
> > clocks = <&clks 61>;
> > fsl,usbphy = <&usbphy1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
> > index 6932928..b6478e9 100644
> > --- a/arch/arm/boot/dts/imx35.dtsi
> > +++ b/arch/arm/boot/dts/imx35.dtsi
> > @@ -318,6 +318,7 @@
> > clocks = <&clks 73>;
> > fsl,usbmisc = <&usbmisc 1>;
> > fsl,usbphy = <&usbphy1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
> > index 620b0f0..e245713 100644
> > --- a/arch/arm/boot/dts/imx50.dtsi
> > +++ b/arch/arm/boot/dts/imx50.dtsi
> > @@ -197,6 +197,7 @@
> > reg = <0x53f80200 0x0200>;
> > interrupts = <14>;
> > clocks = <&clks IMX5_CLK_USB_PHY2_GATE>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -205,6 +206,7 @@
> > reg = <0x53f80400 0x0200>;
> > interrupts = <16>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -213,6 +215,7 @@
> > reg = <0x53f80600 0x0200>;
> > interrupts = <17>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
> > index c0116cf..f46fe9b 100644
> > --- a/arch/arm/boot/dts/imx51.dtsi
> > +++ b/arch/arm/boot/dts/imx51.dtsi
> > @@ -265,6 +265,7 @@
> > interrupts = <14>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -274,6 +275,7 @@
> > interrupts = <16>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -283,6 +285,7 @@
> > interrupts = <17>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 3>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> > index ff4fa7e..c3e3ca9 100644
> > --- a/arch/arm/boot/dts/imx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53.dtsi
> > @@ -309,6 +309,7 @@
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 1>;
> > fsl,usbphy = <&usbphy1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -318,6 +319,7 @@
> > interrupts = <16>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -327,6 +329,7 @@
> > interrupts = <17>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 3>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> > index d6c69ec..9347c93 100644
> > --- a/arch/arm/boot/dts/imx6qdl.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> > @@ -845,6 +845,7 @@
> > clocks = <&clks IMX6QDL_CLK_USBOH3>;
> > fsl,usbphy = <&usbphy2>;
> > fsl,usbmisc = <&usbmisc 1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -854,6 +855,7 @@
> > interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&clks IMX6QDL_CLK_USBOH3>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -863,6 +865,7 @@
> > interrupts = <0 42 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&clks IMX6QDL_CLK_USBOH3>;
> > fsl,usbmisc = <&usbmisc 3>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> > index 36ab8e0..9bf1db3 100644
> > --- a/arch/arm/boot/dts/imx6sl.dtsi
> > +++ b/arch/arm/boot/dts/imx6sl.dtsi
> > @@ -699,6 +699,7 @@
> > interrupts = <0 40 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&clks IMX6SL_CLK_USBOH3>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> > index 7a24fee..fdadd060 100644
> > --- a/arch/arm/boot/dts/imx6sx.dtsi
> > +++ b/arch/arm/boot/dts/imx6sx.dtsi
> > @@ -763,6 +763,7 @@
> > fsl,usbmisc = <&usbmisc 2>;
> > phy_type = "hsic";
> > fsl,anatop = <&anatop>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > --
> > 1.8.4
> >
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
2015-03-03 4:43 ` Peter Chen
@ 2015-03-03 15:08 ` Matt Porter
2015-03-04 0:51 ` Peter Chen
0 siblings, 1 reply; 6+ messages in thread
From: Matt Porter @ 2015-03-03 15:08 UTC (permalink / raw)
To: Peter Chen
Cc: Shawn Guo, Sascha Hauer, Devicetree List, Linux ARM Kernel List,
Linux Kernel Mailing List
On Tue, Mar 03, 2015 at 12:43:36PM +0800, Peter Chen wrote:
> On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote:
> >
> > On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote:
> > > The chipidea driver adds an extra line of spam to the log when a
> > > host-only chipidea instance is left set to the default of a dual role
> > > controller.
> > >
> > > [ 2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget
> > >
> > > Set the dr_mode property to host on all the host-only nodes
> > > to avoid this warning.
>
> It is not an warning, it is dev_info.
True enough, it's info level but is essentially warning that, in the
case of instances that are restricted to host only (at the SoC level),
that the DT hardware description is incorrect. Yes, it's benign, but
if the dtsi is corrected for those parts we don't have to see that
message.
> In fact, imx28, imx6sl and imx6sx's second controller is dual-role
> controller, we only set dr_mode at board's dts according to design
> unless the controller's capability register is incorrect.
The patch doesn't set dr_mode to host on the second controller for
the imx6sl or imx6sx, only on the third host-only controller. If
imx28's second controller is really dual-role capable then the
reference manual is incorrect and I can drop that hunk in v2.
I only have imx6q and imx6d parts in hand to verify so for the rest
I went by the RM claim of which controllers were host-only.
> So, sorry, I don't think this change is necessary.
I can correct the set of instances that should have dr_mode set to host
in v2 of this. We clearly have some that should have this set in their
SoC .dtsi to have the hardware description correct. Will that work for
you or do you want the SoC-specific cases of this property to be only
reflected in the board level dts?
-Matt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
2015-03-03 15:08 ` Matt Porter
@ 2015-03-04 0:51 ` Peter Chen
0 siblings, 0 replies; 6+ messages in thread
From: Peter Chen @ 2015-03-04 0:51 UTC (permalink / raw)
To: Matt Porter
Cc: Shawn Guo, Sascha Hauer, Devicetree List, Linux ARM Kernel List,
Linux Kernel Mailing List
On Tue, Mar 03, 2015 at 10:08:09AM -0500, Matt Porter wrote:
> On Tue, Mar 03, 2015 at 12:43:36PM +0800, Peter Chen wrote:
> > On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote:
> > >
> > > On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote:
> > > > The chipidea driver adds an extra line of spam to the log when a
> > > > host-only chipidea instance is left set to the default of a dual role
> > > > controller.
> > > >
> > > > [ 2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget
> > > >
> > > > Set the dr_mode property to host on all the host-only nodes
> > > > to avoid this warning.
> >
> > It is not an warning, it is dev_info.
>
> True enough, it's info level but is essentially warning that, in the
> case of instances that are restricted to host only (at the SoC level),
> that the DT hardware description is incorrect. Yes, it's benign, but
> if the dtsi is corrected for those parts we don't have to see that
> message.
You are right.
>
> > In fact, imx28, imx6sl and imx6sx's second controller is dual-role
> > controller, we only set dr_mode at board's dts according to design
> > unless the controller's capability register is incorrect.
>
> The patch doesn't set dr_mode to host on the second controller for
> the imx6sl or imx6sx, only on the third host-only controller. If
> imx28's second controller is really dual-role capable then the
> reference manual is incorrect and I can drop that hunk in v2.
> I only have imx6q and imx6d parts in hand to verify so for the rest
> I went by the RM claim of which controllers were host-only.
Maybe IC guys don't want to export that imx28's that capabilities,
so don't need to change.
>
> > So, sorry, I don't think this change is necessary.
>
> I can correct the set of instances that should have dr_mode set to host
> in v2 of this. We clearly have some that should have this set in their
> SoC .dtsi to have the hardware description correct. Will that work for
> you or do you want the SoC-specific cases of this property to be only
> reflected in the board level dts?
>
After thinking more, it is a benefit fix, and doesn't need to do any
changes, thanks.
Acked-by: Peter Chen <peter.chen@freescale.com>
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
2015-02-27 14:06 [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances Matt Porter
2015-03-03 3:41 ` Shawn Guo
@ 2015-03-06 4:40 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2015-03-06 4:40 UTC (permalink / raw)
To: Matt Porter
Cc: Sascha Hauer, Devicetree List, Linux ARM Kernel List,
Linux Kernel Mailing List
On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote:
> The chipidea driver adds an extra line of spam to the log when a
> host-only chipidea instance is left set to the default of a dual role
> controller.
>
> [ 2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget
>
> Set the dr_mode property to host on all the host-only nodes
> to avoid this warning.
>
> Signed-off-by: Matt Porter <mporter@konsulko.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-06 4:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-27 14:06 [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances Matt Porter
2015-03-03 3:41 ` Shawn Guo
2015-03-03 4:43 ` Peter Chen
2015-03-03 15:08 ` Matt Porter
2015-03-04 0:51 ` Peter Chen
2015-03-06 4:40 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).