linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: nand: MTD_NAND_HISI504 should depend on HAS_DMA
@ 2015-03-01  9:35 Geert Uytterhoeven
  2015-03-03  6:58 ` Brian Norris
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-03-01  9:35 UTC (permalink / raw)
  To: Zhou Wang, Brian Norris, David Woodhouse
  Cc: linux-mtd, linux-kernel, Geert Uytterhoeven

If NO_DMA=y:

    drivers/built-in.o: In function `hisi_nfc_probe':
    hisi504_nand.c:(.text+0x23e646): undefined reference to `dmam_alloc_coherent'

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/mtd/nand/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 5b76a173cd95d6d5..5897d8d8fa5a962d 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -526,6 +526,7 @@ config MTD_NAND_SUNXI
 
 config MTD_NAND_HISI504
 	tristate "Support for NAND controller on Hisilicon SoC Hip04"
+	depends on HAS_DMA
 	help
 	  Enables support for NAND controller on Hisilicon SoC Hip04.
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: nand: MTD_NAND_HISI504 should depend on HAS_DMA
  2015-03-01  9:35 [PATCH] mtd: nand: MTD_NAND_HISI504 should depend on HAS_DMA Geert Uytterhoeven
@ 2015-03-03  6:58 ` Brian Norris
  0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2015-03-03  6:58 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Zhou Wang, David Woodhouse, linux-mtd, linux-kernel

On Sun, Mar 01, 2015 at 10:35:52AM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     drivers/built-in.o: In function `hisi_nfc_probe':
>     hisi504_nand.c:(.text+0x23e646): undefined reference to `dmam_alloc_coherent'
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Looks good. Pushed to linux-mtd.git. Thanks!

Brian

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-03  6:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-01  9:35 [PATCH] mtd: nand: MTD_NAND_HISI504 should depend on HAS_DMA Geert Uytterhoeven
2015-03-03  6:58 ` Brian Norris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).