* [PATCH] netlink: drop (int) cast on length arg in NLMSG_OK
@ 2015-03-05 5:47 Mike Frysinger
2015-03-06 2:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2015-03-05 5:47 UTC (permalink / raw)
To: netdev, David S. Miller; +Cc: linux-kernel
The NLMSG_OK macro compares three things:
- the len arg from the user
- a size_t: sizeof(struct nlmsghdr)
- an int: sizeof(struct nlmsghdr) casted
- an u32: the nlmsghdr->nlmsg_len member
When building with -Wsign-compare, this macro triggers a signed compare
warning. This is because it compares len to an int, and then compares
it to a u32. If len is signed, we get a warning due to the last test.
If len is unsigned, we get a warning due to the first test. Like in
strace:
socketutils.c:145:8: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
Lets drop the int cast on the first sizeof. This way, once the user
casts len to an unsigned value, everything shakes out correctly.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
include/uapi/linux/netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h
index 1a85940..3eb4e24 100644
--- a/include/uapi/linux/netlink.h
+++ b/include/uapi/linux/netlink.h
@@ -84,7 +84,7 @@ struct nlmsghdr {
#define NLMSG_DATA(nlh) ((void*)(((char*)nlh) + NLMSG_LENGTH(0)))
#define NLMSG_NEXT(nlh,len) ((len) -= NLMSG_ALIGN((nlh)->nlmsg_len), \
(struct nlmsghdr*)(((char*)(nlh)) + NLMSG_ALIGN((nlh)->nlmsg_len)))
-#define NLMSG_OK(nlh,len) ((len) >= (int)sizeof(struct nlmsghdr) && \
+#define NLMSG_OK(nlh,len) ((len) >= sizeof(struct nlmsghdr) && \
(nlh)->nlmsg_len >= sizeof(struct nlmsghdr) && \
(nlh)->nlmsg_len <= (len))
#define NLMSG_PAYLOAD(nlh,len) ((nlh)->nlmsg_len - NLMSG_SPACE((len)))
--
2.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netlink: drop (int) cast on length arg in NLMSG_OK
2015-03-05 5:47 [PATCH] netlink: drop (int) cast on length arg in NLMSG_OK Mike Frysinger
@ 2015-03-06 2:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-03-06 2:43 UTC (permalink / raw)
To: vapier; +Cc: netdev, linux-kernel
From: Mike Frysinger <vapier@gentoo.org>
Date: Thu, 5 Mar 2015 00:47:08 -0500
> The NLMSG_OK macro compares three things:
> - the len arg from the user
> - a size_t: sizeof(struct nlmsghdr)
> - an int: sizeof(struct nlmsghdr) casted
> - an u32: the nlmsghdr->nlmsg_len member
>
> When building with -Wsign-compare, this macro triggers a signed compare
> warning. This is because it compares len to an int, and then compares
> it to a u32. If len is signed, we get a warning due to the last test.
> If len is unsigned, we get a warning due to the first test. Like in
> strace:
> socketutils.c:145:8: warning: comparison between signed and unsigned
> integer expressions [-Wsign-compare]
>
> Lets drop the int cast on the first sizeof. This way, once the user
> casts len to an unsigned value, everything shakes out correctly.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
I don't think we can change this. If you get rid of the 'int' cast
then code is going to end up with a signed comparison for the first
test even if 'len' is signed, and that's a potential security issue.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-06 2:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 5:47 [PATCH] netlink: drop (int) cast on length arg in NLMSG_OK Mike Frysinger
2015-03-06 2:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).