* [PATCH] net: fec: fix unbalanced clk disable on driver unbind
@ 2015-03-05 14:09 Stefan Agner
2015-03-06 1:22 ` fugang.duan
2015-03-06 3:24 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Agner @ 2015-03-05 14:09 UTC (permalink / raw)
To: davem; +Cc: B38611, netdev, linux-kernel, stefan
When the driver is removed (e.g. using unbind through sysfs), the
clocks get disabled twice, once on fec_enet_close and once on
fec_drv_remove. Since the clocks are enabled only once, this leads
to a warning:
WARNING: CPU: 0 PID: 402 at drivers/clk/clk.c:992 clk_core_disable+0x64/0x68()
Remove the call to fec_enet_clk_enable in fec_drv_remove to balance
the clock enable/disable calls again. This has been introduce by
e8fcfcd5684a ("net: fec: optimize the clock management to save power").
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
drivers/net/ethernet/freescale/fec_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 9bb6220..5fbdf72 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3383,7 +3383,6 @@ fec_drv_remove(struct platform_device *pdev)
regulator_disable(fep->reg_phy);
if (fep->ptp_clock)
ptp_clock_unregister(fep->ptp_clock);
- fec_enet_clk_enable(ndev, false);
of_node_put(fep->phy_node);
free_netdev(ndev);
--
2.3.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] net: fec: fix unbalanced clk disable on driver unbind
2015-03-05 14:09 [PATCH] net: fec: fix unbalanced clk disable on driver unbind Stefan Agner
@ 2015-03-06 1:22 ` fugang.duan
2015-03-06 3:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: fugang.duan @ 2015-03-06 1:22 UTC (permalink / raw)
To: Stefan Agner, davem; +Cc: netdev, linux-kernel
From: Stefan Agner <stefan@agner.ch> Sent: Thursday, March 05, 2015 10:09 PM
> To: davem@davemloft.net
> Cc: Duan Fugang-B38611; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; stefan@agner.ch
> Subject: [PATCH] net: fec: fix unbalanced clk disable on driver unbind
>
> When the driver is removed (e.g. using unbind through sysfs), the clocks
> get disabled twice, once on fec_enet_close and once on fec_drv_remove.
> Since the clocks are enabled only once, this leads to a warning:
>
> WARNING: CPU: 0 PID: 402 at drivers/clk/clk.c:992
> clk_core_disable+0x64/0x68()
>
> Remove the call to fec_enet_clk_enable in fec_drv_remove to balance the
> clock enable/disable calls again. This has been introduce by e8fcfcd5684a
> ("net: fec: optimize the clock management to save power").
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 9bb6220..5fbdf72 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3383,7 +3383,6 @@ fec_drv_remove(struct platform_device *pdev)
> regulator_disable(fep->reg_phy);
> if (fep->ptp_clock)
> ptp_clock_unregister(fep->ptp_clock);
> - fec_enet_clk_enable(ndev, false);
> of_node_put(fep->phy_node);
> free_netdev(ndev);
>
> --
> 2.3.0
Acked-by: Fugang Duan <B38611@freescale.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: fec: fix unbalanced clk disable on driver unbind
2015-03-05 14:09 [PATCH] net: fec: fix unbalanced clk disable on driver unbind Stefan Agner
2015-03-06 1:22 ` fugang.duan
@ 2015-03-06 3:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-03-06 3:24 UTC (permalink / raw)
To: stefan; +Cc: B38611, netdev, linux-kernel
From: Stefan Agner <stefan@agner.ch>
Date: Thu, 5 Mar 2015 15:09:29 +0100
> When the driver is removed (e.g. using unbind through sysfs), the
> clocks get disabled twice, once on fec_enet_close and once on
> fec_drv_remove. Since the clocks are enabled only once, this leads
> to a warning:
>
> WARNING: CPU: 0 PID: 402 at drivers/clk/clk.c:992 clk_core_disable+0x64/0x68()
>
> Remove the call to fec_enet_clk_enable in fec_drv_remove to balance
> the clock enable/disable calls again. This has been introduce by
> e8fcfcd5684a ("net: fec: optimize the clock management to save power").
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-06 3:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 14:09 [PATCH] net: fec: fix unbalanced clk disable on driver unbind Stefan Agner
2015-03-06 1:22 ` fugang.duan
2015-03-06 3:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).