[PATCH 0/17] crypto: talitos - Add support for SEC1

[PATCH 0/17] crypto: talitos - Add support for SEC1

[Christophe Leroy]

The purpose of this set of patchs is to add to talitos crypto driver the
support for the SEC1 version of the security engine, which is found in
mpc885 and mpc8272 processors.

The approach has been to split the driver in two main parts:
* talitos.c and talitos.h contains parts that are common
* talitos2.c and talitos2.h contains specificities of SEC2

Then
* talitos1.c and talitos1.h has been created with SEC1 specificities

Patchset:
[01/17] crypto: talitos - base address for Execution Units and macro for ISR masks
[02/17] crypto: talitos - Externalise specific SEC2 reset actions
[03/17] crypto: talitos - Use zero entry to init descriptors ptrs to zero
[04/17] crypto: talitos - Refactor the sg in/out chain allocation
[05/17] crypto: talitos - isolate scatter/gather handling for ahash
[06/17] crypto: talitos - Add talitos2.c to isolate SEC2 specific functions
[07/17] crypto: talitos - Split talitos.h into 2 parts
[08/17] crypto: talitos - Deport SEC2 error handling
[09/17] crypto: talitos - Move reset/init helpers into talitos2.h
[10/17] crypto: talitos - Move interrupt related macros in talitos2.h
[11/17] crypto: talitos - Move hash chain handling into talitos2.h
[12/17] crypto: talitos - Define compatible in talitos2.h instead of talitos.c
[13/17] crypto: talitos - move sg_count() helper into talitos.h
[14/17] crypto: talitos - Add a helper function to clear j_extent field
[15/17] crypto: talitos - Implementation of SEC1
[16/17] crypto: talitos - SEC1 bugs on 0 data hash
[17/17] crypto: talitos - Update DT bindings with SEC1

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

 .../devicetree/bindings/crypto/fsl-sec2.txt        |   5 +-
 drivers/crypto/Kconfig                             |   8 +
 drivers/crypto/Makefile                            |   2 +
 drivers/crypto/talitos.c                           | 927 +--------------------
 drivers/crypto/talitos.h                           | 185 ++--
 drivers/crypto/talitos1.c                          | 197 +++++
 drivers/crypto/talitos1.h                          | 343 ++++++++
 drivers/crypto/talitos2.c                          | 696 ++++++++++++++++
 drivers/crypto/talitos2.h                          | 335 ++++++++
 9 files changed, 1736 insertions(+), 962 deletions(-)

Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

[Kim Phillips]

On Thu, 5 Mar 2015 17:46:05 +0100
Christophe Leroy <christophe.leroy@c-s.fr> wrote:

> [15/17] crypto: talitos - Implementation of SEC1

...

> [16/17] crypto: talitos - SEC1 bugs on 0 data hash
> [17/17] crypto: talitos - Update DT bindings with SEC1

This patchseries doesn't apply, at least on top of Herbert's
cryptodev-2.6 tree, as of today:

Applying: crypto: talitos - Implementation of SEC1
error: patch failed: drivers/crypto/talitos.c:655
error: drivers/crypto/talitos.c: patch does not apply

Kim

Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

[Herbert Xu]

On Thu, Mar 05, 2015 at 06:21:01PM -0600, Kim Phillips wrote:
> On Thu, 5 Mar 2015 17:46:05 +0100
> Christophe Leroy <christophe.leroy@c-s.fr> wrote:
> 
> > [15/17] crypto: talitos - Implementation of SEC1
> 
> ...
> 
> > [16/17] crypto: talitos - SEC1 bugs on 0 data hash
> > [17/17] crypto: talitos - Update DT bindings with SEC1
> 
> This patchseries doesn't apply, at least on top of Herbert's
> cryptodev-2.6 tree, as of today:
> 
> Applying: crypto: talitos - Implementation of SEC1
> error: patch failed: drivers/crypto/talitos.c:655
> error: drivers/crypto/talitos.c: patch does not apply

Also the patches are coming in a random order.  Please send them
one at a time to ensure proper ordering.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

[leroy christophe]

Le 06/03/2015 01:21, Kim Phillips a écrit :
> On Thu, 5 Mar 2015 17:46:05 +0100
> Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>
>> [15/17] crypto: talitos - Implementation of SEC1
> ...
>
>> [16/17] crypto: talitos - SEC1 bugs on 0 data hash
>> [17/17] crypto: talitos - Update DT bindings with SEC1
> This patchseries doesn't apply, at least on top of Herbert's
> cryptodev-2.6 tree, as of today:
>
> Applying: crypto: talitos - Implementation of SEC1
> error: patch failed: drivers/crypto/talitos.c:655
> error: drivers/crypto/talitos.c: patch does not apply
It was applying ok on linux-next as of yesterday.
I will rebase the serie on cryptodev-2.6

Christophe

Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

[leroy christophe]

Le 06/03/2015 01:28, Herbert Xu a écrit :
> On Thu, Mar 05, 2015 at 06:21:01PM -0600, Kim Phillips wrote:
>> On Thu, 5 Mar 2015 17:46:05 +0100
>> Christophe Leroy <christophe.leroy@c-s.fr> wrote:
>>
>>> [15/17] crypto: talitos - Implementation of SEC1
>> ...
>>
>>> [16/17] crypto: talitos - SEC1 bugs on 0 data hash
>>> [17/17] crypto: talitos - Update DT bindings with SEC1
>> This patchseries doesn't apply, at least on top of Herbert's
>> cryptodev-2.6 tree, as of today:
>>
>> Applying: crypto: talitos - Implementation of SEC1
>> error: patch failed: drivers/crypto/talitos.c:655
>> error: drivers/crypto/talitos.c: patch does not apply
> Also the patches are coming in a random order.  Please send them
> one at a time to ensure proper ordering.
>
> Thanks,
Kim, I have now tried on top of cryptodev-2.6 tree, and for me it works 
(see below).
Do I clone cryptodev-2.6 from the wrong place ?
On that clone, the latest commit on talitos.c is commit 
5be4d4c94b1f98b839344fda7a8752a4a09d0ef5 "crypto: replace 
scatterwalk_sg_next with sg_next"

[root@localhost ~]# git clone 
https://www.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
Cloning into 'cryptodev-2.6'...
remote: Counting objects: 4043448, done.
remote: Compressing objects: 100% (682829/682829), done.
Receiving objects: 100% (4043448/4043448), 893.52 MiB | 258.00 KiB/s, done.
remote: Total 4043448 (delta 3330215), reused 4043104 (delta 3329977)
Resolving deltas: 100% (3330215/3330215), done.
Checking connectivity... done.
Checking out files: 100% (48971/48971), done.
[root@localhost ~]# cd cryptodev-2.6/
[root@localhost cryptodev-2.6]# git branch test
[root@localhost cryptodev-2.6]# git checkout test
Switched to branch 'test'
[root@localhost cryptodev-2.6]# git am 
/root/gen/trunk/submitted_patches/talitos/0*
Applying: crypto: talitos - base address for Execution Units and macro 
for ISR masks
Applying: crypto: talitos - Externalise specific SEC2 reset actions
Applying: crypto: talitos - Use zero entry to init descriptors ptrs to zero
Applying: crypto: talitos - Refactor the sg in/out chain allocation
Applying: crypto: talitos - isolate scatter/gather handling for ahash
Applying: crypto: talitos - Add talitos2.c to isolate SEC2 specific 
functions
Applying: crypto: talitos - Split talitos.h into 2 parts
Applying: crypto: talitos - Deport SEC2 error handling
Applying: crypto: talitos - Move reset/init helpers into talitos2.h
Applying: crypto: talitos - Move interrupt related macros in talitos2.h
Applying: crypto: talitos - Move hash chain handling into talitos2.h
Applying: crypto: talitos - Define compatible in talitos2.h instead of 
talitos.c
Applying: crypto: talitos - move sg_count() helper into talitos.h
Applying: crypto: talitos - Add a helper function to clear j_extent field
Applying: crypto: talitos - Implementation of SEC1
Applying: crypto: talitos - SEC1 bugs on 0 data hash
Applying: crypto: talitos - Update DT bindings with SEC1
[root@localhost cryptodev-2.6]#