* [PATCH] drivers: scsi: Remove null check on sdkp
@ 2015-03-06 2:36 Tapasweni Pathak
2015-03-06 12:12 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Tapasweni Pathak @ 2015-03-06 2:36 UTC (permalink / raw)
To: JBottomley, linux-scsi, linux-kernel; +Cc: julia.lawall, tapaswenipathak
Remove null check on sdkp as it won't be null at this line.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by; Julia Lawall <julia.lawall@lip6.fr>
---
drivers/scsi/sd_dif.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd_dif.c
index 14c7d42..2190639 100644
--- a/drivers/scsi/sd_dif.c
+++ b/drivers/scsi/sd_dif.c
@@ -77,9 +77,6 @@ void sd_dif_config_host(struct scsi_disk *sdkp)
disk->integrity->flags |= BLK_INTEGRITY_DEVICE_CAPABLE;
- if (!sdkp)
- return;
-
if (type == SD_DIF_TYPE3_PROTECTION)
disk->integrity->tag_size = sizeof(u16) + sizeof(u32);
else
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: scsi: Remove null check on sdkp
2015-03-06 2:36 [PATCH] drivers: scsi: Remove null check on sdkp Tapasweni Pathak
@ 2015-03-06 12:12 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2015-03-06 12:12 UTC (permalink / raw)
To: Tapasweni Pathak; +Cc: JBottomley, linux-scsi, linux-kernel, julia.lawall
>>>>> "Tapasweni" == Tapasweni Pathak <tapaswenipathak@gmail.com> writes:
Tapasweni> Remove null check on sdkp as it won't be null at this line.
Thanks for the heads up. It's actually a merge snafu. The check is
supposed to be if (!sdkp->ATO). I already have a patch in my queue to
fix this.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-06 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-06 2:36 [PATCH] drivers: scsi: Remove null check on sdkp Tapasweni Pathak
2015-03-06 12:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).