Re: [RFC 3/4] power_supply: Introduce charger control interface

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2726 bytes --]

Hi,

On Fri, Mar 06, 2015 at 04:03:26PM +0530, Jenny TC wrote:
> Introduce power_supply charger control interfaces to control
> charging from charging framework like charger-manager. The interfaces
> are similar to the existing power supply get/set interfaces, but
> introduce a different set of properties in order to differentiate
> itself from other power supply properties which exposed in sysfs
> 
> Signed-off-by: Jenny TC <jenny.tc@intel.com>
> ---
>  include/linux/power_supply.h |   28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index 30145d8e..a80a3ef 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -176,6 +176,32 @@ union power_supply_propval {
>  struct device;
>  struct device_node;
>  
> +enum psy_charger_control_property {
> +	PSY_CHARGER_PROP_ENABLE_CHARGING = 0,
> +	PSY_CHARGER_PROP_ENABLE_CHARGER,
> +	PSY_CHARGER_PROP_RESET_WDT,
> +};
> +
> +/**
> + * struct power_supply_charger - power supply charger driver
> + * @get_property: get property function to retrieve charger properties defined
> + *	in enum power_supply_charger_property
> + * @set_property: get property function to retrieve charger properties defined
> + *	in enum power_supply_charger_property
> + *
> + * This structure is used by charger drivers to register with power supply
> + * charging driver
> + */
> +
> +struct power_supply_charger {
> +	int (*get_property)(struct power_supply_charger *psyc,
> +			    enum psy_charger_control_property pspc,
> +			    union power_supply_propval *val);

The charging framework can simply call the same get_property
as used by sysfs. This is already done by all kind of drivers.

> +	int (*set_property)(struct power_supply_charger *psyc,
> +			    enum psy_charger_control_property pspc,
> +			    const union power_supply_propval *val);

I guess this is needed for values, which are supposed to be
writable by the kernel / charging framework, but non-writable
by the sysfs. I suggest to add set_property_kernel() instead
(and make the above properties part of enum power_supply_property)

> +};
> +
>  struct power_supply {
>  	const char *name;
>  	enum power_supply_type type;
> @@ -200,6 +226,8 @@ struct power_supply {
>  	void (*external_power_changed)(struct power_supply *psy);
>  	void (*set_charged)(struct power_supply *psy);
>  
> +	struct power_supply_charger *psy_charger;

Why is this a pointer?

> +
>  	/*
>  	 * Set if thermal zone should not be created for this power supply.
>  	 * For example for virtual supplies forwarding calls to actual

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]