From: "Tc, Jenny" <jenny.tc@intel.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Anton Vorontsov" <anton.vorontsov@linaro.org>,
David Woodhouse <dwmw2@infradead.org>,
"jonghwa3.lee@samsung.com" <jonghwa3.lee@samsung.com>,
"myungjoo.ham@gmail.com" <myungjoo.ham@gmail.com>,
"Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>
Subject: RE: [RFC 4/4] charger-manager: Enable psy based charge control
Date: Tue, 10 Mar 2015 05:21:29 +0000 [thread overview]
Message-ID: <20ADAB092842284E95860F279283C5642EECB1F5@BGSMSX104.gar.corp.intel.com> (raw)
In-Reply-To: <20150308021409.GC25160@earth>
Hi,
> On Fri, Mar 06, 2015 at 04:03:27PM +0530, Jenny TC wrote:
> > At present charger manager support only regulator based charging
> > control. But most of the charger drivers are registered with power
> > supply subsystem. This patch adds support for power supply based
> > charging control along with the regulator based control. With the
> > patch, charging control can be done either using power supply
> > interface or with regulator interface. The charging is setup
> > based on battery parameters received through the battery info
> > handlers.
>
> [...]
>
> (so far I only skipped over the patch)
Appreciate if you could review entire patch. I will submit next patch set
addressing all your comments.
> [...]
>
> > @@ -1704,6 +1968,10 @@ static int charger_manager_probe(struct
> platform_device *pdev)
> > strncpy(cm->psy_name_buf, desc->psy_name, PSY_NAME_MAX);
> > cm->charger_psy.name = cm->psy_name_buf;
> >
> > + if (!power_supply_get_property(fuel_gauge,
> POWER_SUPPLY_PROP_MODEL_NAME,
> > + &val))
> > + cm->battery_info = psy_get_battery_info(val.strval);
> > +
> > /* Allocate for psy properties because they may vary */
> > cm->charger_psy.properties = devm_kzalloc(&pdev->dev,
> > sizeof(enum power_supply_property)
>
> We are currently splitting battery data from fuel gauge data, so
> acquiring the battery using the fuel gauge's MODEL_NAME is not very
> nice.
Will enhance struct charger_desc{ ..} to support list of battery model name
supported. This can be used to query battery_info using psy_get_battery_info()
-Jenny
prev parent reply other threads:[~2015-03-10 5:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 10:33 [RFC 0/4] Enable power supply charging control Jenny TC
2015-03-06 10:33 ` [RFC 1/4] power_supply: Introduce charging object table Jenny TC
2015-03-06 11:12 ` Oliver Neukum
2015-03-08 1:31 ` Sebastian Reichel
2015-03-08 1:00 ` Sebastian Reichel
2015-03-06 10:33 ` [RFC 2/4] power: core: Add generic interface to get battery specification Jenny TC
2015-03-06 11:16 ` Oliver Neukum
2015-03-09 11:24 ` jonghwa3.lee
2015-03-06 10:33 ` [RFC 3/4] power_supply: Introduce charger control interface Jenny TC
2015-03-08 1:55 ` Sebastian Reichel
2015-03-09 12:47 ` Tc, Jenny
2015-03-09 14:55 ` Sebastian Reichel
2015-03-06 10:33 ` [RFC 4/4] charger-manager: Enable psy based charge control Jenny TC
2015-03-08 2:14 ` Sebastian Reichel
2015-03-10 5:21 ` Tc, Jenny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20ADAB092842284E95860F279283C5642EECB1F5@BGSMSX104.gar.corp.intel.com \
--to=jenny.tc@intel.com \
--cc=anton.vorontsov@linaro.org \
--cc=dwmw2@infradead.org \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@gmail.com \
--cc=ramakrishna.pallala@intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).