* Re: [PATCH] kernel:Change the function definiton of do_exit to comply with its function prototypes in kernel.h
[not found] <1426048610-6065-1-git-send-email-xerofoify@gmail.com>
@ 2015-03-12 23:16 ` Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2015-03-12 23:16 UTC (permalink / raw)
To: Nicholas Krause
Cc: oleg, mhocko, mingo, peterz, ionut.m.alexa, riel, peter, linux-kernel
On Wed, 11 Mar 2015 00:36:50 -0400 Nicholas Krause <xerofoify@gmail.com> wrote:
> This fixes the function definiton of do_exit to comply with its
> function prototype as defined in kernel.h as found when running
> sparse on the latest updated version of the mainline kernel.
>
> ...
>
> -void do_exit(long code)
> +void do_exit(long error_code)
We still have
include/linux/module.h:#define module_put_and_exit(code) do_exit(code)
Probably changing the header files is the way to go - error_code is a
bit of a mouthful.
Actually, using "exit_code" everywhere would be best - that's what the
thing does, and it gets copied into task_struct.exit_code.
And change complete_and_exit(code).
do_group_exit() already uses exit_code.
sys_exit_group() uses "error_code".
It's rather a little mess we've made in there!
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-03-12 23:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1426048610-6065-1-git-send-email-xerofoify@gmail.com>
2015-03-12 23:16 ` [PATCH] kernel:Change the function definiton of do_exit to comply with its function prototypes in kernel.h Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).