From: Ingo Molnar <mingo@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Minchan Kim <minchan@kernel.org>,
Joonsoo Kim <js1304@gmail.com>
Subject: Re: [RFC/PATCHSET 0/6] perf kmem: Implement page allocation analysis (v1)
Date: Fri, 13 Mar 2015 13:44:20 +0100 [thread overview]
Message-ID: <20150313124420.GA4261@gmail.com> (raw)
In-Reply-To: <20150313081930.GA10836@danjae.skbroadband>
* Namhyung Kim <namhyung@kernel.org> wrote:
> Hi Ingo,
>
> On Thu, Mar 12, 2015 at 04:54:22PM +0100, Ingo Molnar wrote:
> >
> > * Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > > > I.e. something like this (mockup) output:
> > > >
> > > > SUMMARY (page allocator)
> > > > ========================
> > > >
> > > > Pages allocated+freed: 12,593 [ 51,630,080 bytes ]
> > > >
> > > > Pages allocated-only: 2,342 [ 1,235,010 bytes ]
> > > > Pages freed-only: 67 [ 135,311 bytes ]
> > > >
> > > > Page allocation failures : 0
> > >
> > > Looks a lot better!
> > >
> > > One thing I need to tell you is that the numbers are not pages but
> > > requests.
> >
> > Yes, but in the MM code we tend to call larger order allocations
> > 'pages' as well: higher order pages, such as a 2MB hugepage, or a 8K
> > order-1 page. So at least in MM-speak it should be OK to call them
> > 'pages'.
> >
> > But your call!
>
> How about this?
>
> SUMMARY (page allocator)
> ========================
> Total allocation requests : 9,015 [ 37,200 Kbytes ] (A)
> Total free requests : 8,093 [ 33,176 Kbytes ] (B)
>
> Total alloc+freed requests : 7,985 [ 32,732 Kbytes ] (C)
> Total alloc-only requests : 1,030 [ 4,468 Kbytes ] (D)
> Total free-only requests : 108 [ 444 Kbytes ] (E)
>
> Total allocation failure : 0 [ 0 Kbytes ]
s/failure/failures
s/Kbytes/KB
I'd leave a bit more space for the numbers, for up into billions of
requests and terabytes of data. Other than that, sounds good to me!
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-13 12:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 7:32 [RFC/PATCHSET 0/6] perf kmem: Implement page allocation analysis (v1) Namhyung Kim
2015-03-12 7:32 ` [PATCH 1/6] perf kmem: Fix segfault when invalid sort key is given Namhyung Kim
2015-03-14 7:06 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-03-12 7:32 ` [PATCH 2/6] perf kmem: Allow -v option Namhyung Kim
2015-03-14 7:06 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-03-12 7:32 ` [PATCH 3/6] perf kmem: Fix alignment of slab result table Namhyung Kim
2015-03-14 7:07 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-03-12 7:32 ` [PATCH 4/6] perf kmem: Analyze page allocator events also Namhyung Kim
2015-03-12 11:01 ` Jiri Olsa
2015-03-12 15:11 ` Namhyung Kim
2015-03-12 7:32 ` [PATCH 5/6] perf kmem: Implement stat --page --caller Namhyung Kim
2015-03-12 7:32 ` [PATCH 6/6] perf kmem: Support sort keys on page analysis Namhyung Kim
2015-03-12 10:41 ` [RFC/PATCHSET 0/6] perf kmem: Implement page allocation analysis (v1) Ingo Molnar
2015-03-12 14:58 ` Namhyung Kim
2015-03-12 15:54 ` Ingo Molnar
2015-03-13 8:19 ` Namhyung Kim
2015-03-13 12:44 ` Ingo Molnar [this message]
2015-03-16 2:06 ` Namhyung Kim
2015-03-16 2:10 ` Namhyung Kim
2015-03-16 8:26 ` Ingo Molnar
2015-03-16 8:35 ` Namhyung Kim
2015-03-16 8:43 ` Ingo Molnar
2015-03-12 19:07 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313124420.GA4261@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).