From: Ingo Molnar <mingo@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Minchan Kim <minchan@kernel.org>,
Joonsoo Kim <js1304@gmail.com>
Subject: Re: [RFC/PATCHSET 0/6] perf kmem: Implement page allocation analysis (v1)
Date: Mon, 16 Mar 2015 09:43:27 +0100 [thread overview]
Message-ID: <20150316084326.GA19820@gmail.com> (raw)
In-Reply-To: <CAM9d7ch=yrF5ej3=ukNZCouq3ddbJ+QNZoeABH+Tm=Lqg0buhw@mail.gmail.com>
* Namhyung Kim <namhyung@kernel.org> wrote:
> Hi Ingo,
>
> On Mon, Mar 16, 2015 at 5:26 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Namhyung Kim <namhyung@kernel.org> wrote:
> >
> >> On Thu, Mar 12, 2015 at 11:58:37PM +0900, Namhyung Kim wrote:
> >> > On Thu, Mar 12, 2015 at 11:41:19AM +0100, Ingo Molnar wrote:
> >> > > So there's one thing that would be useful: to track pages allocated on
> >> > > one node, but freed on another. Those kinds of allocation/free
> >> > > patterns are especially expensive and might make sense to visualize.
> >> >
> >> > I think it can be done easily as slab analysis already contains the info.
> >>
> >> Hmm.. it seems slab events provide the node info but page events
> >> don't. Without it, I don't know which node a page is in so
> >> cannot determine such cross-node alloc+free patterns.
> >
> > Well, but we know the CPU that the allocation occured on, and can
> > map the CPU to the node.
>
> Does it gaurantee that the page always belongs to a same node
> allocating cpu is in? I can simply map the page with an node using
> cpu info but was not sure whether that's always correct.
There's no such guarantee :-(
We try to (and generally we succeed in) allocating on the same node,
but tooling really needs to know about the memory pressure and other
corner cases as well to be dependable.
I suspect we need a new trace_mm_page_alloc tracepoint, and a
CONFIG_DEBUG_MM_TRACE_PAGE_COMPAT setting to phase out the old
tracepoint on new distros?
Then we'd also have to track page migration to be able to track the
full lifetime of a node in tooling: I think most of the tracepoints
are in place, but it has to be checked whether coverage is
comprehensive.
Thanks,
Ingo
next prev parent reply other threads:[~2015-03-16 8:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 7:32 [RFC/PATCHSET 0/6] perf kmem: Implement page allocation analysis (v1) Namhyung Kim
2015-03-12 7:32 ` [PATCH 1/6] perf kmem: Fix segfault when invalid sort key is given Namhyung Kim
2015-03-14 7:06 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-03-12 7:32 ` [PATCH 2/6] perf kmem: Allow -v option Namhyung Kim
2015-03-14 7:06 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-03-12 7:32 ` [PATCH 3/6] perf kmem: Fix alignment of slab result table Namhyung Kim
2015-03-14 7:07 ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-03-12 7:32 ` [PATCH 4/6] perf kmem: Analyze page allocator events also Namhyung Kim
2015-03-12 11:01 ` Jiri Olsa
2015-03-12 15:11 ` Namhyung Kim
2015-03-12 7:32 ` [PATCH 5/6] perf kmem: Implement stat --page --caller Namhyung Kim
2015-03-12 7:32 ` [PATCH 6/6] perf kmem: Support sort keys on page analysis Namhyung Kim
2015-03-12 10:41 ` [RFC/PATCHSET 0/6] perf kmem: Implement page allocation analysis (v1) Ingo Molnar
2015-03-12 14:58 ` Namhyung Kim
2015-03-12 15:54 ` Ingo Molnar
2015-03-13 8:19 ` Namhyung Kim
2015-03-13 12:44 ` Ingo Molnar
2015-03-16 2:06 ` Namhyung Kim
2015-03-16 2:10 ` Namhyung Kim
2015-03-16 8:26 ` Ingo Molnar
2015-03-16 8:35 ` Namhyung Kim
2015-03-16 8:43 ` Ingo Molnar [this message]
2015-03-12 19:07 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316084326.GA19820@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).