From: Pavel Machek <pavel@ucw.cz>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
pali.rohar@gmail.com, sre@debian.org, sre@ring0.de,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi,
ivo.g.dimitrov.75@gmail.com
Subject: Re: [PATCHv2] thermal: add omap3 support
Date: Fri, 13 Mar 2015 20:40:25 +0100 [thread overview]
Message-ID: <20150313194025.GA22182@amd> (raw)
In-Reply-To: <20150313050300.GA30104@developer>
Hi!
> > @@ -384,25 +385,10 @@ int ti_bandgap_set_sensor_data(struct ti_bandgap *bgp, int id, void *data);
> > void *ti_bandgap_get_sensor_data(struct ti_bandgap *bgp, int id);
> > int ti_bandgap_get_trend(struct ti_bandgap *bgp, int id, int *trend);
> >
> > -#ifdef CONFIG_OMAP4_THERMAL
> > +extern const struct ti_bandgap_data omap34xx_data;
> > extern const struct ti_bandgap_data omap4430_data;
> > extern const struct ti_bandgap_data omap4460_data;
> > extern const struct ti_bandgap_data omap4470_data;
> > -#else
> > -#define omap4430_data NULL
> > -#define omap4460_data NULL
> > -#define omap4470_data NULL
> > -#endif
> > -
> > -#ifdef CONFIG_OMAP5_THERMAL
> > extern const struct ti_bandgap_data omap5430_data;
> > -#else
> > -#define omap5430_data NULL
> > -#endif
> > -
> > -#ifdef CONFIG_DRA752_THERMAL
> > extern const struct ti_bandgap_data dra752_data;
> > -#else
> > -#define dra752_data NULL
> > -#endif
>
> Pavel,
>
> Why do we need to remove the existing symbols for other chips in this file to get OMAP3 support in?
>
No, I don't need to remove this, and you can safely drop this hunk.
OTOH those ifdefs are unneccessary and eye-sore: extern symbol
declarations do not really hurt, and .c files already contain enough
#ifdefs for other reasons that the symbols will not be needed when it
is not configured.
Try it, it should work ok.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-03-13 19:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 11:11 [PATCH] thermal: add omap3 support Pavel Machek
2015-01-03 12:34 ` Eduardo Valentin
2015-01-03 22:02 ` Pavel Machek
2015-01-05 21:41 ` Eduardo Valentin
2015-01-18 20:28 ` [PATCHv2] " Pavel Machek
2015-03-13 5:03 ` Eduardo Valentin
2015-03-13 19:40 ` Pavel Machek [this message]
2015-03-13 12:09 ` Pavel Machek
2015-03-13 16:53 ` Eduardo Valentin
2015-03-14 18:02 ` Pavel Machek
2015-03-23 11:25 ` Pavel Machek
2015-03-23 14:31 ` Eduardo Valentin
2015-03-23 15:58 ` Pavel Machek
2015-03-23 17:55 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313194025.GA22182@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=edubezval@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=rui.zhang@intel.com \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).