* [PATCH] net/mlx4_core: Add configfs entries for setting device specific parameters [net-next: fix err_cast.cocci warnings
[not found] <201503160206.B9vUvBdJ%fengguang.wu@intel.com>
@ 2015-03-15 18:01 ` kbuild test robot
2015-03-16 2:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-03-15 18:01 UTC (permalink / raw)
To: Hadar Hen Zion; +Cc: kbuild-all, Poli, netdev, linux-kernel
drivers/net/ethernet/mellanox/mlx4/conf.c:218:9-16: WARNING: ERR_CAST can be used with pdev
Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
Generated by: scripts/coccinelle/api/err_cast.cocci
CC: Hadar Hen Zion <hadarh@mellanox.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/mellanox/mlx4/conf.c
+++ b/drivers/net/ethernet/mellanox/mlx4/conf.c
@@ -215,7 +215,7 @@ static struct config_group *mlx4_set_con
pdev = find_pdev_by_name(name);
if (IS_ERR(pdev))
- return ERR_PTR(PTR_ERR(pdev));
+ return ERR_CAST(pdev);
pdev_config = kzalloc(sizeof(*pdev_config), GFP_KERNEL);
if (!pdev_config) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/mlx4_core: Add configfs entries for setting device specific parameters [net-next: fix err_cast.cocci warnings
2015-03-15 18:01 ` [PATCH] net/mlx4_core: Add configfs entries for setting device specific parameters [net-next: fix err_cast.cocci warnings kbuild test robot
@ 2015-03-16 2:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-03-16 2:26 UTC (permalink / raw)
To: fengguang.wu; +Cc: hadarh, kbuild-all, a, netdev, linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Date: Mon, 16 Mar 2015 02:01:25 +0800
> drivers/net/ethernet/mellanox/mlx4/conf.c:218:9-16: WARNING: ERR_CAST can be used with pdev
>
>
> Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
>
> Generated by: scripts/coccinelle/api/err_cast.cocci
>
> CC: Hadar Hen Zion <hadarh@mellanox.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Doesn't even come close to applying to net-next, please respin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-16 2:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201503160206.B9vUvBdJ%fengguang.wu@intel.com>
2015-03-15 18:01 ` [PATCH] net/mlx4_core: Add configfs entries for setting device specific parameters [net-next: fix err_cast.cocci warnings kbuild test robot
2015-03-16 2:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).