[RFC] proc: change /proc/stat show

* [RFC] proc: change /proc/stat show
@ 2015-03-17  9:42 Wang, Yalin
  2015-03-17 23:02 ` David Rientjes
  0 siblings, 1 reply; 6+ messages in thread
From: Wang, Yalin @ 2015-03-17  9:42 UTC (permalink / raw)
  To: 'akpm@linux-foundation.org',
	'heiko.carstens@de.ibm.com', 'tglx@linutronix.de',
	'rientjes@google.com',
	'linux-kernel@vger.kernel.org'

This patch change /proc/stat to show each cpu,
we show each present cpus instead of eacn online cpu,
because some cpus are online / offline dynamically,
we should also show its cputime even it is offline,
some lib will read this file to detect cpu numbers,
we should also return the real present cpu numbers,
not just online cpus.

Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
---
 fs/proc/stat.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/proc/stat.c b/fs/proc/stat.c
index 510413eb..60b39e2 100644
--- a/fs/proc/stat.c
+++ b/fs/proc/stat.c
@@ -130,7 +130,7 @@ static int show_stat(struct seq_file *p, void *v)
 	seq_put_decimal_ull(p, ' ', cputime64_to_clock_t(guest_nice));
 	seq_putc(p, '\n');
 
-	for_each_online_cpu(i) {
+	for_each_present_cpu(i) {
 		/* Copy values here to work around gcc-2.95.3, gcc-2.96 */
 		user = kcpustat_cpu(i).cpustat[CPUTIME_USER];
 		nice = kcpustat_cpu(i).cpustat[CPUTIME_NICE];
@@ -153,6 +153,7 @@ static int show_stat(struct seq_file *p, void *v)
 		seq_put_decimal_ull(p, ' ', cputime64_to_clock_t(steal));
 		seq_put_decimal_ull(p, ' ', cputime64_to_clock_t(guest));
 		seq_put_decimal_ull(p, ' ', cputime64_to_clock_t(guest_nice));
+		seq_printf(p, " %d", cpu_online(i)? 1 : 0);
 		seq_putc(p, '\n');
 	}
 	seq_printf(p, "intr %llu", (unsigned long long)sum);
-- 
2.2.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread