crypto: img-hash - undefined Kconfig symbols

crypto: img-hash - undefined Kconfig symbols

[Valentin Rothberg]

Hi James,

your commit d358f1abbf71 ("crypto: img-hash - Add Imagination
Technologies hw hash accelerator") adds two selects on undefined
Kconfig symbols, namely CRYPTO_ALG_API and CRYPTO_SHA224.

The first symbols looks like a typo since there is an option
CRYPTO_ALGAPI defined in crypto/Kconfig.  However, I do not find a
companion for CRYPTO_SHA224.  Is there a patch scheduled somewhere
that adds this option?

I detected your commit in today's Linux next tree by running
./scripts/checkkconfigsymbols.py.  Git commit 92503ee4ada1
("checkkconfigsymbols.py: make it Git aware") added the functionality
to check Git commits and diff commits for such undefined symbols.

Kind regards,
 Valentin

Re: crypto: img-hash - undefined Kconfig symbols

[James Hartley]

Hi Valentin,


> On 18 Mar 2015, at 01:35, Valentin Rothberg <valentinrothberg@gmail.com> wrote:
> 
> Hi James,
> 
> your commit d358f1abbf71 ("crypto: img-hash - Add Imagination
> Technologies hw hash accelerator") adds two selects on undefined
> Kconfig symbols, namely CRYPTO_ALG_API and CRYPTO_SHA224.
> 
> The first symbols looks like a typo since there is an option
> CRYPTO_ALGAPI defined in crypto/Kconfig.  

Yes, that's a typo - it should be CRYPTO_ALGAPI

> However, I do not find a
> companion for CRYPTO_SHA224.  Is there a patch scheduled somewhere
> that adds this option?

No, I think that option is just incorrect and should be removed.

> 
> I detected your commit in today's Linux next tree by running
> ./scripts/checkkconfigsymbols.py.  Git commit 92503ee4ada1
> ("checkkconfigsymbols.py: make it Git aware") added the functionality
> to check Git commits and diff commits for such undefined symbols.

Great, I'll use it in future. Thanks for the notification. 

> 
> Kind regards,
> Valentin

Herbert: should I send you a patch to address the issues above, or resubmit the series with the fixes incorporated?

Thanks
James 

Re: crypto: img-hash - undefined Kconfig symbols

[Herbert Xu]

On Wed, Mar 18, 2015 at 01:02:14PM +0000, James Hartley wrote:
>
> Herbert: should I send you a patch to address the issues above, or resubmit the series with the fixes incorporated?

James, your patch has already been merged so please send any
fixes on top of the cryptodev tree.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: img-hash: Fix Kconfig selections

[James Hartley]

The Kconfig entry for CRYPTO_DEV_IMGTEC_HASH incorrectly selects
CRYPTO_SHA224, which does not exist (and is covered by CRYPTO_SHA256
which covers both 224 and 256). Remove it.

Also correct typo CRYPTO_ALG_API to be CRYPTO_ALGPI.

Reported-by: Valentin Rothberg <valentinrothberg@gmail.com>
Signed-off-by: James Hartley <james.hartley@imgtec.com>
---
 drivers/crypto/Kconfig |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 8b18b66..800bf41 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -448,10 +448,9 @@ source "drivers/crypto/vmx/Kconfig"
 config CRYPTO_DEV_IMGTEC_HASH
 	depends on MIPS || COMPILE_TEST
 	tristate "Imagination Technologies hardware hash accelerator"
-	select CRYPTO_ALG_API
+	select CRYPTO_ALGAPI
 	select CRYPTO_MD5
 	select CRYPTO_SHA1
-	select CRYPTO_SHA224
 	select CRYPTO_SHA256
 	select CRYPTO_HASH
 	help
-- 
1.7.9.5

Re: [PATCH] crypto: img-hash: Fix Kconfig selections

[Herbert Xu]

On Thu, Mar 19, 2015 at 04:46:24PM +0000, James Hartley wrote:
> The Kconfig entry for CRYPTO_DEV_IMGTEC_HASH incorrectly selects
> CRYPTO_SHA224, which does not exist (and is covered by CRYPTO_SHA256
> which covers both 224 and 256). Remove it.
> 
> Also correct typo CRYPTO_ALG_API to be CRYPTO_ALGPI.
> 
> Reported-by: Valentin Rothberg <valentinrothberg@gmail.com>
> Signed-off-by: James Hartley <james.hartley@imgtec.com>

Applied.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt