linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters
Date: Thu, 19 Mar 2015 10:43:14 -0700	[thread overview]
Message-ID: <20150319174314.GA17329@roeck-us.net> (raw)
In-Reply-To: <20150319081612.GA900@katana>

On Thu, Mar 19, 2015 at 09:16:21AM +0100, Wolfram Sang wrote:
> 
> > I don't call that multi-master, though, so I guess we may have a bit of a
> > terminology problem.
> 
> This is definately not a multi-master issue, I agree. It is just
> another issue I saw when thinking about your patch thoroughly again.
> 
> > I'll see what I can come up with, but I am not sure if I'll find the time
> > before the 4.1 commit window opens. Company has a working solution (kind of),
> > so now I'll have to do this on my own time ;-).
> 
> But their solution is buggy and needs a fix! :)
> 
Turns out this is really easy to reproduce. One process reads
the eeprom over and over again, another runs i2cdump in a loop,
and voila ... lots of corruptions. Scary, especially considering
how wide-spread this kind of i2c access is in the kernel.

Guenter

  parent reply	other threads:[~2015-03-19 17:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 16:23 [PATCH] eeprom: at24: Add support for large EEPROMs connected to SMBus adapters Guenter Roeck
2015-02-04 17:47 ` Wolfram Sang
2015-02-04 19:08   ` Guenter Roeck
2015-02-04 23:35     ` Wolfram Sang
2015-02-05  0:26       ` Guenter Roeck
2015-02-05 14:40         ` Wolfram Sang
2015-02-05 17:53           ` Guenter Roeck
2015-02-12  4:01             ` Guenter Roeck
2015-02-16 12:09               ` Wolfram Sang
2015-02-16 15:37                 ` Guenter Roeck
2015-03-17  4:20                 ` Guenter Roeck
2015-03-18 13:27                   ` Wolfram Sang
2015-03-19  3:24                     ` Guenter Roeck
2015-03-19  8:16                       ` Wolfram Sang
2015-03-19 13:30                         ` Guenter Roeck
2015-03-19 17:43                         ` Guenter Roeck [this message]
2015-03-19 21:39                           ` Wolfram Sang
2015-03-25 14:11                             ` Guenter Roeck
2015-03-25 16:15                               ` Wolfram Sang
2015-03-25 16:37                                 ` Guenter Roeck
2015-03-27  8:09                               ` Wolfram Sang
2015-03-27 12:51                                 ` Guenter Roeck
2015-03-27 13:01                                   ` Wolfram Sang
2015-03-27 13:14                                     ` Guenter Roeck
2015-03-27 15:27                                       ` Wolfram Sang
2015-03-27 15:42                                         ` Guenter Roeck
2015-02-04 20:33   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319174314.GA17329@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).