From: Tejun Heo <tj@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org,
richard@nod.at, "Frédéric Weisbecker" <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v6 2/3] cgroups: allow a cgroup subsystem to reject a fork
Date: Thu, 26 Mar 2015 11:08:06 -0400 [thread overview]
Message-ID: <20150326150806.GB1953@htj.duckdns.org> (raw)
In-Reply-To: <CAOviyagGvm4z8eAWitR267U3br-60vVJ9A5MMtFENy9xt9zuLQ@mail.gmail.com>
On Sat, Mar 21, 2015 at 10:25:56PM +1100, Aleksa Sarai wrote:
> > Also, what pins the cset between task_css_set() and get_css_set()?
> > task_css_set() is protected by RCU and the above should have triggered
> > RCU warning if the debug option is enabled. Please always test with
> > the debug options enabled, especially the lockdep and RCU ones.
>
> Debug was enabled AFAIK and I didn't get anything in `dmesg`. I've fixed it
> anyway.
So, this is worrying. If you have RCU debugging enabled, it should
have triggered the warning. If it hadn't, maybe there's something
else protecting it and we don't need the extra rcu locking around it.
Can you please investigate what's going on?
Thanks.
--
tejun
next prev parent reply other threads:[~2015-03-26 15:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 4:37 [PATCH v6 0/3] cgroups: add pids subsystem Aleksa Sarai
2015-03-14 4:37 ` [PATCH v6 1/3] cgroups: use bitmask to filter for_each_subsys Aleksa Sarai
2015-03-16 16:42 ` Tejun Heo
2015-03-14 4:37 ` [PATCH v6 2/3] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-03-16 16:53 ` Tejun Heo
2015-03-21 11:25 ` Aleksa Sarai
2015-03-26 15:08 ` Tejun Heo [this message]
2015-03-26 14:38 ` Aleksa Sarai
2015-03-26 15:02 ` Tejun Heo
2015-03-26 21:41 ` Aleksa Sarai
2015-03-26 22:18 ` Tejun Heo
2015-03-14 4:37 ` [PATCH v6 3/3] cgroups: add a pids subsystem Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326150806.GB1953@htj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).