From: Mark Brown <broonie@kernel.org>
To: Scott Branden <sbranden@broadcom.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Dmitry Torokhov <dtor@google.com>,
Anatol Pomazao <anatol@google.com>,
abrestic@google.com, bryeung@google.com, olofj@google.com,
pwestin@google.com, Lori Hikichi <lhikichi@broadcom.com>
Subject: Re: [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings
Date: Tue, 31 Mar 2015 06:58:06 +0100 [thread overview]
Message-ID: <20150331055806.GB2869@sirena.org.uk> (raw)
In-Reply-To: <1427771784-29950-2-git-send-email-sbranden@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
On Mon, Mar 30, 2015 at 08:16:23PM -0700, Scott Branden wrote:
> +SSP Subnode properties:
> +- dai-name: The name of the DAI registered with ASOC
ASoC.
Why is this in the DT - it sounds like this is just an internal
implementation detail for Linux, not a property of the hardware.
> +- mode: Controls if this port should be configured as I2S or TDM mode.
> + Valid values are: "tdm" or "i2s"
> +- tdm-bits-per-frame: only if mode is "tdm" then this property must set.
> + Valid values are (128/256/512)
We'd normally leave these up to the machine driver to set as they're
link wide things for system integration. The bits per frame in
particular looks like something that's not going to be fixed by the
hardware and could be varied at runtime.
> +- port-status: Controls if port is enabled or not
> + Valid values "enabled" or "disabled"
This sounds like it's replicating the DT standard status property?
> +- channel-group: Control grouping of serial port
> + Valid values are "2_0", "3_1", or "5_1"
What does this mean? It looks like it's setting the number of channels
which again seems like a runtime thing.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-31 5:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 3:16 [PATCH 0/2] Cygnus Audio Driver Scott Branden
2015-03-31 3:16 ` [PATCH 1/2] ASoC: cygnus-audio: adding device tree bindings Scott Branden
2015-03-31 5:58 ` Mark Brown [this message]
2015-04-02 18:47 ` Lori Hikichi
2015-03-31 7:00 ` Mark Brown
2015-03-31 7:26 ` [alsa-devel] " Lars-Peter Clausen
2015-04-02 22:44 ` Lori Hikichi
2015-03-31 3:16 ` [PATCH 2/2] ASoC: add core audio driver for Broadcom Cygnus SOC Scott Branden
2015-03-31 6:42 ` Mark Brown
2015-04-02 18:47 ` Lori Hikichi
2015-04-06 16:19 ` Mark Brown
2015-04-08 2:30 ` Lori Hikichi
2015-04-08 19:23 ` Mark Brown
2015-04-10 2:06 ` Lori Hikichi
2015-03-31 6:43 ` [PATCH 0/2] Cygnus Audio Driver Mark Brown
2015-04-03 19:33 ` Scott Branden
2015-04-06 9:58 ` Mark Brown
2015-04-08 2:28 ` Lori Hikichi
2015-04-08 18:54 ` Mark Brown
2015-04-11 3:06 ` Lori Hikichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331055806.GB2869@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abrestic@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=anatol@google.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bryeung@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dtor@google.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=lhikichi@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=olofj@google.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=pwestin@google.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).