From: Andrew Morton <akpm@linux-foundation.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Philipp Hachtmann <phacht@linux.vnet.ibm.com>,
Fabian Frederick <fabf@skynet.be>,
Catalin Marinas <catalin.marinas@arm.com>,
Emil Medve <Emilian.Medve@freescale.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
Tony Luck <tony.luck@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memblock: add debug output for the memblock_add
Date: Tue, 31 Mar 2015 16:38:08 -0700 [thread overview]
Message-ID: <20150331163808.6ffa50f3140b50828bd5dba8@linux-foundation.org> (raw)
In-Reply-To: <1427562483-29839-1-git-send-email-kuleshovmail@gmail.com>
On Sat, 28 Mar 2015 23:08:03 +0600 Alexander Kuleshov <kuleshovmail@gmail.com> wrote:
> memblock_reserve function calls memblock_reserve_region which
> prints debugging information if 'memblock=debug' passed to the
> command line. This patch adds the same behaviour, but for the
> memblock_add function.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> mm/memblock.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 252b77b..c7b8306 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -580,10 +580,24 @@ int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size,
> return memblock_add_range(&memblock.memory, base, size, nid, 0);
> }
>
> +static int __init_memblock memblock_add_region(phys_addr_t base,
> + phys_addr_t size,
> + int nid,
> + unsigned long flags)
> +{
> + struct memblock_type *_rgn = &memblock.memory;
> +
> + memblock_dbg("memblock_memory: [%#016llx-%#016llx] flags %#02lx %pF\n",
I guess this should be "memblock_add:". That's what
memblock_reserve_region() does?
--- a/mm/memblock.c~mm-memblock-add-debug-output-for-the-memblock_add-fix
+++ a/mm/memblock.c
@@ -587,7 +587,7 @@ static int __init_memblock memblock_add_
{
struct memblock_type *_rgn = &memblock.memory;
- memblock_dbg("memblock_memory: [%#016llx-%#016llx] flags %#02lx %pF\n",
+ memblock_dbg("memblock_add: [%#016llx-%#016llx] flags %#02lx %pF\n",
(unsigned long long)base,
(unsigned long long)base + size - 1,
flags, (void *)_RET_IP_);
_
next prev parent reply other threads:[~2015-03-31 23:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 17:08 [PATCH] mm/memblock: add debug output for the memblock_add Alexander Kuleshov
2015-03-31 23:38 ` Andrew Morton [this message]
2015-04-01 7:21 ` Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331163808.6ffa50f3140b50828bd5dba8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Emilian.Medve@freescale.com \
--cc=akinobu.mita@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=fabf@skynet.be \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=phacht@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).