From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Philipp Hachtmann <phacht@linux.vnet.ibm.com>,
Fabian Frederick <fabf@skynet.be>,
Catalin Marinas <catalin.marinas@arm.com>,
Emil Medve <Emilian.Medve@freescale.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
Tang Chen <tangchen@cn.fujitsu.com>,
Tony Luck <tony.luck@intel.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/memblock: add debug output for the memblock_add
Date: Wed, 1 Apr 2015 13:21:25 +0600 [thread overview]
Message-ID: <CANCZXo52sHS_2QP=mSkPayqo5A02DzN9j=m3ZQN++4v9GcTu0g@mail.gmail.com> (raw)
In-Reply-To: <20150331163808.6ffa50f3140b50828bd5dba8@linux-foundation.org>
2015-04-01 5:38 GMT+06:00 Andrew Morton <akpm@linux-foundation.org>:
> On Sat, 28 Mar 2015 23:08:03 +0600 Alexander Kuleshov <kuleshovmail@gmail.com> wrote:
>
> I guess this should be "memblock_add:". That's what
> memblock_reserve_region() does?
>
> --- a/mm/memblock.c~mm-memblock-add-debug-output-for-the-memblock_add-fix
> +++ a/mm/memblock.c
> @@ -587,7 +587,7 @@ static int __init_memblock memblock_add_
> {
> struct memblock_type *_rgn = &memblock.memory;
>
> - memblock_dbg("memblock_memory: [%#016llx-%#016llx] flags %#02lx %pF\n",
> + memblock_dbg("memblock_add: [%#016llx-%#016llx] flags %#02lx %pF\n",
> (unsigned long long)base,
> (unsigned long long)base + size - 1,
> flags, (void *)_RET_IP_);
> _
>
Yes, it is much cleaner. Thank you Andrew.
prev parent reply other threads:[~2015-04-01 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 17:08 [PATCH] mm/memblock: add debug output for the memblock_add Alexander Kuleshov
2015-03-31 23:38 ` Andrew Morton
2015-04-01 7:21 ` Alexander Kuleshov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANCZXo52sHS_2QP=mSkPayqo5A02DzN9j=m3ZQN++4v9GcTu0g@mail.gmail.com' \
--to=kuleshovmail@gmail.com \
--cc=Emilian.Medve@freescale.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=phacht@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).