* [PATCH net-next] vxge: Add const to ethtool_driver_stats_keys
@ 2015-04-01 19:29 Joe Perches
2015-04-01 19:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2015-04-01 19:29 UTC (permalink / raw)
To: Jon Mason; +Cc: David S. Miller, netdev, LKML
Move about half a KB of data to text.
Miscellanea:
o Move strings out of the .h file into the .c file
in case the .h file is ever #included twice
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/ethernet/neterion/vxge/vxge-ethtool.c | 19 +++++++++++++++++++
drivers/net/ethernet/neterion/vxge/vxge-ethtool.h | 19 -------------------
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c
index b07d552..be916eb 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.c
@@ -18,6 +18,25 @@
#include "vxge-ethtool.h"
+static const char ethtool_driver_stats_keys[][ETH_GSTRING_LEN] = {
+ {"\n DRIVER STATISTICS"},
+ {"vpaths_opened"},
+ {"vpath_open_fail_cnt"},
+ {"link_up_cnt"},
+ {"link_down_cnt"},
+ {"tx_frms"},
+ {"tx_errors"},
+ {"tx_bytes"},
+ {"txd_not_free"},
+ {"txd_out_of_desc"},
+ {"rx_frms"},
+ {"rx_errors"},
+ {"rx_bytes"},
+ {"rx_mcast"},
+ {"pci_map_fail_cnt"},
+ {"skb_alloc_fail_cnt"}
+};
+
/**
* vxge_ethtool_sset - Sets different link parameters.
* @dev: device pointer.
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.h b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.h
index 6cf3044..065a2c0 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-ethtool.h
+++ b/drivers/net/ethernet/neterion/vxge/vxge-ethtool.h
@@ -19,25 +19,6 @@
/* Ethtool related variables and Macros. */
static int vxge_ethtool_get_sset_count(struct net_device *dev, int sset);
-static char ethtool_driver_stats_keys[][ETH_GSTRING_LEN] = {
- {"\n DRIVER STATISTICS"},
- {"vpaths_opened"},
- {"vpath_open_fail_cnt"},
- {"link_up_cnt"},
- {"link_down_cnt"},
- {"tx_frms"},
- {"tx_errors"},
- {"tx_bytes"},
- {"txd_not_free"},
- {"txd_out_of_desc"},
- {"rx_frms"},
- {"rx_errors"},
- {"rx_bytes"},
- {"rx_mcast"},
- {"pci_map_fail_cnt"},
- {"skb_alloc_fail_cnt"}
-};
-
#define VXGE_TITLE_LEN 5
#define VXGE_HW_VPATH_STATS_LEN 27
#define VXGE_HW_AGGR_STATS_LEN 13
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] vxge: Add const to ethtool_driver_stats_keys
2015-04-01 19:29 [PATCH net-next] vxge: Add const to ethtool_driver_stats_keys Joe Perches
@ 2015-04-01 19:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-04-01 19:35 UTC (permalink / raw)
To: joe; +Cc: jdmason, netdev, linux-kernel
From: Joe Perches <joe@perches.com>
Date: Wed, 01 Apr 2015 12:29:13 -0700
> Move about half a KB of data to text.
>
> Miscellanea:
>
> o Move strings out of the .h file into the .c file
> in case the .h file is ever #included twice
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks Joe.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-01 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-01 19:29 [PATCH net-next] vxge: Add const to ethtool_driver_stats_keys Joe Perches
2015-04-01 19:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).