* [PATCH] Staging: rtl8192u Make function static
@ 2015-03-31 23:51 Eddie Kovsky
2015-04-01 3:39 ` Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Eddie Kovsky @ 2015-03-31 23:51 UTC (permalink / raw)
To: gregkh, cristina.opriceana, gdonald, mahfouz.saif.elyazal,
benoit.taine, dan.carpenter
Cc: devel, linux-kernel
Changing function definition to static fixes the
following warning generated by sparse:
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol 'ieee80211_check_auth_response' was not declared. Should it be static?
Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
index 66b158714822..072d8204b01c 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
@@ -1921,7 +1921,7 @@ static void ieee80211_process_action(struct ieee80211_device *ieee,
}
-void ieee80211_check_auth_response(struct ieee80211_device *ieee,
+static void ieee80211_check_auth_response(struct ieee80211_device *ieee,
struct sk_buff *skb)
{
/* default support N mode, disable halfNmode */
--
2.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: rtl8192u Make function static
2015-03-31 23:51 [PATCH] Staging: rtl8192u Make function static Eddie Kovsky
@ 2015-04-01 3:39 ` Sudip Mukherjee
2015-04-01 4:24 ` Eddie Kovsky
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-04-01 3:39 UTC (permalink / raw)
To: Eddie Kovsky
Cc: gregkh, cristina.opriceana, gdonald, mahfouz.saif.elyazal,
benoit.taine, dan.carpenter, devel, linux-kernel
On Tue, Mar 31, 2015 at 05:51:19PM -0600, Eddie Kovsky wrote:
> Changing function definition to static fixes the
> following warning generated by sparse:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol 'ieee80211_check_auth_response' was not declared. Should it be static?
some one has already done this and it has been already applied to
staging-testing.
regards
sudip
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: rtl8192u Make function static
2015-04-01 3:39 ` Sudip Mukherjee
@ 2015-04-01 4:24 ` Eddie Kovsky
0 siblings, 0 replies; 3+ messages in thread
From: Eddie Kovsky @ 2015-04-01 4:24 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: gregkh, cristina.opriceana, gdonald, mahfouz.saif.elyazal,
benoit.taine, dan.carpenter, devel, linux-kernel
On Wed, Apr 01, 2015 at 09:09:26AM +0530, Sudip Mukherjee wrote:
> On Tue, Mar 31, 2015 at 05:51:19PM -0600, Eddie Kovsky wrote:
> > Changing function definition to static fixes the
> > following warning generated by sparse:
> >
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: symbol 'ieee80211_check_auth_response' was not declared. Should it be static?
>
> some one has already done this and it has been already applied to
> staging-testing.
>
> regards
> sudip
>
Yes, I see that now. I thought I was already tracking that branch.
I'm sorry for the noise.
Eddie
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-01 4:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-31 23:51 [PATCH] Staging: rtl8192u Make function static Eddie Kovsky
2015-04-01 3:39 ` Sudip Mukherjee
2015-04-01 4:24 ` Eddie Kovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).