* [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"
@ 2015-03-27 20:36 Witos
2015-03-28 6:26 ` Sudip Mukherjee
2015-04-03 11:42 ` [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool" Greg Kroah-Hartman
0 siblings, 2 replies; 8+ messages in thread
From: Witos @ 2015-03-27 20:36 UTC (permalink / raw)
To: William Hubbs
Cc: Chris Brannon, Kirk Reiser, Samuel Thibault, Greg Kroah-Hartman,
speakup, devel, linux-kernel, trivial
Changed bool to u8 to get rid of sparse warning.
Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
---
drivers/staging/speakup/fakekey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
index 4299cf4..3dfb6bd 100644
--- a/drivers/staging/speakup/fakekey.c
+++ b/drivers/staging/speakup/fakekey.c
@@ -28,7 +28,7 @@
#define PRESSED 1
#define RELEASED 0
-static DEFINE_PER_CPU(bool, reporting_keystroke);
+static DEFINE_PER_CPU(u8, reporting_keystroke);
static struct input_dev *virt_keyboard;
--
2.0.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"
2015-03-27 20:36 [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool" Witos
@ 2015-03-28 6:26 ` Sudip Mukherjee
2015-03-28 7:57 ` Piotr Witosławski
2015-04-03 11:42 ` [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool" Greg Kroah-Hartman
1 sibling, 1 reply; 8+ messages in thread
From: Sudip Mukherjee @ 2015-03-28 6:26 UTC (permalink / raw)
To: Witos
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, speakup, devel, linux-kernel, trivial
On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> Changed bool to u8 to get rid of sparse warning.
but i am not getting this warning. which version of sparse are you
using?
and why you have sent the same patch two times?
regards
sudip
>
> Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"
2015-03-28 6:26 ` Sudip Mukherjee
@ 2015-03-28 7:57 ` Piotr Witosławski
2015-03-30 6:19 ` Sudip Mukherjee
0 siblings, 1 reply; 8+ messages in thread
From: Piotr Witosławski @ 2015-03-28 7:57 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, speakup, devel, linux-kernel, trivial
On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote:
> On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> > Changed bool to u8 to get rid of sparse warning.
> but i am not getting this warning. which version of sparse are you
> using?
sparse 0.5.0, see: http://yarchive.net/comp/linux/bool.html
> and why you have sent the same patch two times?
sorry my mistake, first time I wanted send it to myself, I forgot
that I filled CC list.
>
> regards
> sudip
>
> >
> > Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"
2015-03-28 7:57 ` Piotr Witosławski
@ 2015-03-30 6:19 ` Sudip Mukherjee
2015-03-30 7:09 ` [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"peakup@linux-speakup.org, Piotr Witosławski
0 siblings, 1 reply; 8+ messages in thread
From: Sudip Mukherjee @ 2015-03-30 6:19 UTC (permalink / raw)
To: Piotr Witosławski
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, speakup, devel, linux-kernel, trivial
On Sat, Mar 28, 2015 at 08:57:01AM +0100, Piotr Witosławski wrote:
> On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote:
> > On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> > > Changed bool to u8 to get rid of sparse warning.
> > but i am not getting this warning. which version of sparse are you
> > using?
>
> sparse 0.5.0, see: http://yarchive.net/comp/linux/bool.html
looks like you have done quite a lot of research on it .. :)
i am using 0.5.0-22-gd92353b, and my sparse is not showing me this
warning.
regards
sudip
>
> > and why you have sent the same patch two times?
>
> sorry my mistake, first time I wanted send it to myself, I forgot
> that I filled CC list.
>
> >
> > regards
> > sudip
> >
> > >
> > > Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"peakup@linux-speakup.org,
2015-03-30 6:19 ` Sudip Mukherjee
@ 2015-03-30 7:09 ` Piotr Witosławski
0 siblings, 0 replies; 8+ messages in thread
From: Piotr Witosławski @ 2015-03-30 7:09 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: William Hubbs, Chris Brannon, Kirk Reiser, Samuel Thibault,
Greg Kroah-Hartman, speakup, devel, linux-kernel, trivial
On Mon, Mar 30, 2015 at 11:49:53AM +0530, Sudip Mukherjee wrote:
> On Sat, Mar 28, 2015 at 08:57:01AM +0100, Piotr Witosławski wrote:
> > On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote:
> > > On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> > > > Changed bool to u8 to get rid of sparse warning.
> > > but i am not getting this warning. which version of sparse are you
> > > using?
> >
> > sparse 0.5.0, see: http://yarchive.net/comp/linux/bool.html
> looks like you have done quite a lot of research on it .. :)
> i am using 0.5.0-22-gd92353b, and my sparse is not showing me this
> warning.
Checked it on the git source, it was moved from default
to the -Wsizeof-bool flag with commit: 2667c2d4ab3342b54283d16f1d62e6d715f3b373.
That's why I got the warning and you didn't. If you turn on this flag,
you'll get it. It's not really anything important, I'm doing a patch for the
eudyptula-challange, if you don't accept it, I'll find sth else in
drivers/staging.
>
> regards
> sudip
> >
> > > and why you have sent the same patch two times?
> >
> > sorry my mistake, first time I wanted send it to myself, I forgot
> > that I filled CC list.
> >
> > >
> > > regards
> > > sudip
> > >
> > > >
> > > > Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"
2015-03-27 20:36 [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool" Witos
2015-03-28 6:26 ` Sudip Mukherjee
@ 2015-04-03 11:42 ` Greg Kroah-Hartman
1 sibling, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2015-04-03 11:42 UTC (permalink / raw)
To: Witos
Cc: William Hubbs, devel, Kirk Reiser, trivial, speakup,
linux-kernel, Samuel Thibault, Chris Brannon
On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> Changed bool to u8 to get rid of sparse warning.
>
> Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
> ---
> drivers/staging/speakup/fakekey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
> index 4299cf4..3dfb6bd 100644
> --- a/drivers/staging/speakup/fakekey.c
> +++ b/drivers/staging/speakup/fakekey.c
> @@ -28,7 +28,7 @@
> #define PRESSED 1
> #define RELEASED 0
>
> -static DEFINE_PER_CPU(bool, reporting_keystroke);
> +static DEFINE_PER_CPU(u8, reporting_keystroke);
Why send this twice?
And again, I don't think this is fixing anything, what is wrong with
this code?
confused,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"
2015-03-27 20:29 Witos
@ 2015-04-03 11:42 ` Greg Kroah-Hartman
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2015-04-03 11:42 UTC (permalink / raw)
To: Witos
Cc: devel, Kirk Reiser, trivial, speakup, linux-kernel,
Samuel Thibault, Chris Brannon
On Fri, Mar 27, 2015 at 09:29:43PM +0100, Witos wrote:
> Changed bool to u8.
>
> Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
Your From: email line and signed-off-by: line names do not match, so I
can't take this patch :(
Please fix up and resend.
> ---
> drivers/staging/speakup/fakekey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
> index 4299cf4..3dfb6bd 100644
> --- a/drivers/staging/speakup/fakekey.c
> +++ b/drivers/staging/speakup/fakekey.c
> @@ -28,7 +28,7 @@
> #define PRESSED 1
> #define RELEASED 0
>
> -static DEFINE_PER_CPU(bool, reporting_keystroke);
> +static DEFINE_PER_CPU(u8, reporting_keystroke);
What is this fixing? Why can't we have a bool as a per-cpu variable?
We are only writing true or false to it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"
@ 2015-03-27 20:29 Witos
2015-04-03 11:42 ` Greg Kroah-Hartman
0 siblings, 1 reply; 8+ messages in thread
From: Witos @ 2015-03-27 20:29 UTC (permalink / raw)
To: pwitos
Cc: Chris Brannon, Kirk Reiser, Samuel Thibault, Greg Kroah-Hartman,
speakup, devel, linux-kernel, trivial
Changed bool to u8.
Signed-off-by: Piotr Witoslawski <pwitos@gmail.com>
---
drivers/staging/speakup/fakekey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
index 4299cf4..3dfb6bd 100644
--- a/drivers/staging/speakup/fakekey.c
+++ b/drivers/staging/speakup/fakekey.c
@@ -28,7 +28,7 @@
#define PRESSED 1
#define RELEASED 0
-static DEFINE_PER_CPU(bool, reporting_keystroke);
+static DEFINE_PER_CPU(u8, reporting_keystroke);
static struct input_dev *virt_keyboard;
--
2.0.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-04-03 11:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-27 20:36 [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool" Witos
2015-03-28 6:26 ` Sudip Mukherjee
2015-03-28 7:57 ` Piotr Witosławski
2015-03-30 6:19 ` Sudip Mukherjee
2015-03-30 7:09 ` [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"peakup@linux-speakup.org, Piotr Witosławski
2015-04-03 11:42 ` [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool" Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2015-03-27 20:29 Witos
2015-04-03 11:42 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).