* [PATCH] crypto: CRYPTO_DEV_IMGTEC_HASH should depend on HAS_DMA
@ 2015-04-23 18:03 Geert Uytterhoeven
2015-04-24 12:20 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-04-23 18:03 UTC (permalink / raw)
To: Herbert Xu, David S. Miller
Cc: linux-crypto, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
drivers/built-in.o: In function `img_hash_write_via_dma_stop':
img-hash.c:(.text+0xa2b822): undefined reference to `dma_unmap_sg'
drivers/built-in.o: In function `img_hash_xmit_dma':
img-hash.c:(.text+0xa2b8d8): undefined reference to `dma_map_sg'
img-hash.c:(.text+0xa2b948): undefined reference to `dma_unmap_sg'
Also move the "depends" section below the "tristate" line while we're at
it.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/crypto/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 800bf41718e185e8..033c0c86f6ec051a 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -446,8 +446,9 @@ config CRYPTO_DEV_VMX
source "drivers/crypto/vmx/Kconfig"
config CRYPTO_DEV_IMGTEC_HASH
- depends on MIPS || COMPILE_TEST
tristate "Imagination Technologies hardware hash accelerator"
+ depends on MIPS || COMPILE_TEST
+ depends on HAS_DMA
select CRYPTO_ALGAPI
select CRYPTO_MD5
select CRYPTO_SHA1
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: CRYPTO_DEV_IMGTEC_HASH should depend on HAS_DMA
2015-04-23 18:03 [PATCH] crypto: CRYPTO_DEV_IMGTEC_HASH should depend on HAS_DMA Geert Uytterhoeven
@ 2015-04-24 12:20 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-04-24 12:20 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: David S. Miller, linux-crypto, linux-kernel
On Thu, Apr 23, 2015 at 08:03:58PM +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `img_hash_write_via_dma_stop':
> img-hash.c:(.text+0xa2b822): undefined reference to `dma_unmap_sg'
> drivers/built-in.o: In function `img_hash_xmit_dma':
> img-hash.c:(.text+0xa2b8d8): undefined reference to `dma_map_sg'
> img-hash.c:(.text+0xa2b948): undefined reference to `dma_unmap_sg'
>
> Also move the "depends" section below the "tristate" line while we're at
> it.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-24 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-23 18:03 [PATCH] crypto: CRYPTO_DEV_IMGTEC_HASH should depend on HAS_DMA Geert Uytterhoeven
2015-04-24 12:20 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).